Triplet check in FastSim #14083
Triplet check in FastSim #14083
Conversation
…terations can directly use it for triplet check in FastSim
…cted a typo in the lowPtStep config
…lSim so that triplet check can be used in tobTecStep of FastSim Tracking
|
A new Pull Request was created by @Ansh0712 (Anshul Kapoor) for CMSSW_8_1_X. It involves the following packages: FastSimulation/Tracking @civanch, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| const RecHitsSortedInPhi* thm=new RecHitsSortedInPhi (thirdHits, selectedTrackingRegion->origin(), thirdLayer); | ||
| if(pixelTripletGeneratorPtr){ | ||
| OrderedHitTriplets Tripletresult; | ||
| pixelTripletGeneratorPtr->hitTriplets(*selectedTrackingRegion,Tripletresult,es,*hitDoublets,&thm,thirdLayerDetLayer,1); |
There was a problem hiding this comment.
Here you use the hitDoublets again to retrieve the information. You assume that together with the third hit these form a triplet that satisfies the seeding layers. I think there can be cases where this is not true, e.g. if you have two hits for the first layer, then you get two doublets where the first one is overridden by the next one and hence the two hits in the doublets are not identical to the hits with which this method is called.
There was a problem hiding this comment.
We are making assumptions on how the loop over the seeding tree happens.
It's definitely error prone...
We need to discuss this.
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
| ) | ||
|
|
||
| #del mixedTripletStepSeedsB.pixelTripletGeneratorFactory.SeedComparitorPSet |
| const DetLayer * thirdLayer = measurementTracker->geometricSearchTracker()->detLayer(thirdHit->det()->geographicalId()); | ||
| std::vector<const DetLayer *> thirdLayerDetLayer(1,thirdLayer); | ||
| std::vector<BaseTrackerRecHit const *> thirdHits(1,(const BaseTrackerRecHit*) thirdHit->hit()); | ||
| const RecHitsSortedInPhi* thm=new RecHitsSortedInPhi (thirdHits, selectedTrackingRegion->origin(), thirdLayer); |
There was a problem hiding this comment.
where do these get deleted?
static analyzer points to a possible mem leak
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14083/12448/llvm-analysis/report-7e5631.html#EndPath
There was a problem hiding this comment.
It's a memory leak indeed.
We are making some changes to the seedfinder class to allow for a cleaner selector that doesn't require new statements, is easier to read and a bit more robust.
|
@slava77 @lveldere @matt-komm @makortel Thanks all, suggestions will be implemented in a new pull request. If you have more suggestions in the mean while, you can comment on this thread also. |
|
Why new pull request? |
|
-1 |
|
This PR looks obsolete - will close. |
|
Yes, obsolete indeed. On Fri, Apr 29, 2016 at 11:18 AM, David Lange notifications@github.com
|
FastSim now checks if a triplet is compatible with tracking region constraints.
The validation plots are available here : http://test-folders.web.cern.ch/test-Folders/plots_TripletFull_11April/