Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring L1T (nearly) too l1t-tsg-v5 (80x version) #14092

Closed
wants to merge 8 commits into from
Closed

Bring L1T (nearly) too l1t-tsg-v5 (80x version) #14092

wants to merge 8 commits into from

Conversation

mulhearn
Copy link
Contributor

@mulhearn mulhearn commented Apr 15, 2016 •
edited

This is the 80x version of #14104.

@mulhearn
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Apr 15, 2016
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12407/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mulhearn for CMSSW_8_0_X.

It involves the following packages:

CondFormats/L1TObjects
DataFormats/L1Trigger
EventFilter/L1TRawToDigi
EventFilter/L1TXRawToDigi
L1Trigger/Configuration
L1Trigger/L1TCaloLayer1
L1Trigger/L1TCalorimeter
L1Trigger/L1TCommon
L1Trigger/L1TGlobal
L1Trigger/L1TMuon
L1Trigger/L1TMuonBarrel
L1Trigger/L1TMuonEndCap

@cerminar, @cmsbuild, @rekovic, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ghellwig, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mulhearn mulhearn mentioned this pull request Apr 15, 2016
Open
@cmsbuild
Copy link
Contributor

-1
Tested at: c2482a3
When I ran the RelVals I found an error in the following worklfows:
10021.0 step2

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step2_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log
----- Begin Fatal Exception 15-Apr-2016 18:36:51 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1_DIGI2RAW.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file L1Trigger/L1TCalorimeter/data/Tau_Calibration_LUT_Layer1Calibration_v9.0.0.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-04-14-2300/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-04-14-2300/external/slc6_amd64_gcc530/data:/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-04-14-2300/src:/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-04-14-2300/external/slc6_amd64_gcc530/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017
----- End Fatal Exception -------------------------------------------------

10024.0 step2

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log
----- Begin Fatal Exception 15-Apr-2016 18:50:43 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1_DIGI2RAW.py
Exception Message:
python encountered the error: 
edm::FileInPath unable to find file L1Trigger/L1TCalorimeter/data/Tau_Calibration_LUT_Layer1Calibration_v9.0.0.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-04-14-2300/src:/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-04-14-2300/external/slc6_amd64_gcc530/data:/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-04-14-2300/src:/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-04-14-2300/external/slc6_amd64_gcc530/data
Current directory is: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14092/12407/summary.html
'List

@mulhearn
Copy link
Contributor Author

It looks like those two relval failures will go away as soon as the externals are merged...

@mulhearn
Copy link
Contributor Author

No, sorry, misfire there. Let me see whats going on.

@mulhearn
Copy link
Contributor Author

(Note that the only failures were in era Run2_2017.)

@mulhearn
Copy link
Contributor Author

This is failing because this guy: cms-data/L1Trigger-L1TCalorimeter#9
hasn't gone into 80x as well yet!

@mulhearn
Copy link
Contributor Author

This one should be there too: cms-data/L1Trigger-L1TGlobal#3

@smuzaffar
Copy link
Contributor

data externals should be in 23h00 80X IB ( cms-sw/cmsdist#2257)

@mulhearn mulhearn mentioned this pull request Apr 15, 2016
Merged
@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#2257

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#2257
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/34/console
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/35/console

@cmsbuild cmsbuild mentioned this pull request Apr 15, 2016
Merged
@mulhearn mulhearn force-pushed the pr-l1t-integration-v34.0-80x branch from c9d8ce9 to 974da07 Compare April 17, 2016 19:55
@cmsbuild
Copy link
Contributor

Pull request #14092 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again.

@mulhearn
Copy link
Contributor Author

please test with cms-sw/cmsdist#2257

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#2257
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/37/console

@mulhearn
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12468/console

@mulhearn
Copy link
Contributor Author

Just noting that this needs an update to be made in sync with 81x version (which changed).

@mulhearn
Copy link
Contributor Author

This has now been superseded by #14141.

@mulhearn mulhearn closed this Apr 19, 2016
@cmsbuild
Copy link
Contributor

+1
Tested at: 974da07
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14092/12468/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14092/12468/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available l1-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mulhearn @cmsbuild @smuzaffar @l-cadamuro