Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed static analyzer warning in PuppiProducer.cc & TrackerMap.cc #14111

Merged
merged 2 commits into from Apr 19, 2016

Conversation

uhussain
Copy link
Contributor

By deleting the line 160: closestVtx = &(*(lPack->vertexRef()));

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @uhussain for CMSSW_8_1_X.

It involves the following packages:

CommonTools/PileupAlgos

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ahinzmann, @jdolen, @rappoccio this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

Pull request #14111 was updated. @cvuosalo, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

@uhussain uhussain changed the title Fixed static analyzer warning in PuppiProducer.cc Fixed static analyzer warning in PuppiProducer.cc & TrackerMap.cc Apr 17, 2016
@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12438/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #14111 0076ec4

Fixing static analyzer warnings in PuppiProducer.cc and TrackerMap.cc. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-04-15-2300 show no significant differences, as expected.

@davidlange6 davidlange6 merged commit aaa7b32 into cms-sw:CMSSW_8_1_X Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants