Update to L1t Global for 2016 Menu #14112
Conversation
|
A new Pull Request was created by @mulhearn for CMSSW_8_0_X. It involves the following packages: CondFormats/DataRecord @perrotta, @cmsbuild, @cerminar, @Martin-Grunewald, @rekovic, @franzoni, @fwyzard, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
|
-1 Tested at: 6b8f91f The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build ClangBuild
I found an error when building: Leaving library rule at DataFormats/L1TGlobal
>> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-04-14-2300/src/DQM/L1TMonitor/src/L1TdeCSCTF.cc
>> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-04-14-2300/src/DQM/L1TMonitor/src/L1TGMT.cc
>> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-04-14-2300/src/DQM/L1TMonitor/src/L1TStage2BMTF.cc
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-04-14-2300/src/DQM/L1TMonitor/src/L1TStage2uGT.cc: In member function 'virtual void L1TStage2uGT::analyze(const edm::Event&, const edm::EventSetup&)':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-04-14-2300/src/DQM/L1TMonitor/src/L1TStage2uGT.cc:163:24: error: 'const class GlobalAlgBlk' has no member named 'getAlgoDecisionPreScaled'
if(itr->getAlgoDecisionPreScaled(algoBit)) {
^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-04-14-2300/src/DQM/L1TMonitor/src/L1TStage2uGT.cc:170:30: error: 'const class GlobalAlgBlk' has no member named 'getAlgoDecisionPreScaled'
if(itr->getAlgoDecisionPreScaled(algoBit2)) {
^
I found a compilation error while trying to compile with clang: >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-04-14-2300/src/EventFilter/L1TRawToDigi/plugins/AMCDumpToRaw.cc >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-04-14-2300/src/EventFilter/L1TRawToDigi/plugins/L1TDigiToRaw.cc >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-04-14-2300/src/EventFilter/L1TRawToDigi/plugins/L1TValidationEventFilter.cc >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-04-14-2300/src/EventFilter/L1TRawToDigi/plugins/TMTFilter.cc >> Compile sequence completed for CMSSW CMSSW_8_0_X_2016-04-14-2300 gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
cmsbuild
added
tests-rejected
comparison-pending
dqm-pending
tests-pending
and removed
comparison-notrun
tests-started
tests-rejected
labels
|
Pull request #14112 was updated. @perrotta, @cmsbuild, @cerminar, @Martin-Grunewald, @rekovic, @franzoni, @deguio, @fwyzard, @ggovi, @mmusich, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
|
This is history is pure garbage, I cannot read it and it sends emails to large group of people. What does it mean "testing only"? Clean it up. No one in sane mind will look at this PR with 600K lines in diff! |
|
"Testing Only" means I am the only one that should be looking at the moment... I've made that more clear in the summary now. I can't do anything about the e-mails, as this is a major change that touches many changes during testing, I need Jenkins, and it relies on another PR that hasn't been merged yet. On this list of things I am worried about, reducing mail from cmsbuild is very low on the list. Just use -1! |
|
If it's your development branch then you shouldn't make a PR. It's not ready for people to review it. You build it locally. Nothing is stoping you from pulling in other PRs locally on which you depend on. I don't see a connection here between "not yet merged PR" and Jenkins. |
|
Pull request #14112 was updated. @perrotta, @cmsbuild, @cerminar, @Martin-Grunewald, @rekovic, @franzoni, @deguio, @fwyzard, @ggovi, @mmusich, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Pull request #14112 was updated. @perrotta, @cmsbuild, @cerminar, @Martin-Grunewald, @rekovic, @franzoni, @deguio, @fwyzard, @ggovi, @mmusich, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again. |
|
-1 Tested at: e0c9ad0 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-04-21-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Apr 22 09:48:52 2016-date Fri Apr 22 09:43:44 2016 s - exit: 16640 |
|
-1 Tested at: e0c9ad0 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-04-21-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Apr 22 09:49:34 2016-date Fri Apr 22 09:45:20 2016 s - exit: 16640 |
|
-1 |
This is currently for testing only. No one else needs to read further.
This updates L1T Global with correlation conditions and other features needed to implement the 2016 trigger.