Fix for emulator match problem and incorrect tower binning.

[tanmaymudholkar]

(1) Fixed emulator match problem where, if two adjacent channels were saturated in energy, the emulated and data TP showed a match at two values
(2) Fixed incorrect trigger tower binning because of which emulator matches for TTs in a given TCC would overflow into the next TCC.

[cmsbuild]

A new Pull Request was created by @tanmaymudholkar (Tanmay Mudholkar) for CMSSW_8_1_X.

It involves the following packages:

DQM/EcalCommon
DQM/EcalMonitorTasks

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[davidlt]

The commit subject line is not good enough, "Two changes:" provides no information.

[tanmaymudholkar]

Thanks @davidlt , is the subject line good enough now or should I make it more descriptive?

[deguio]

please test

[deguio]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12583/console

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

@tanmaymudholkar @deguio - could all of these magic numbers (changing for a not really obvious reason) - be made instead constants with readable names? Thanks!

[cmsbuild]

+1
Tested at: f666d11
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14118/12583/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14118/12583/summary.html

[tanmaymudholkar]

@davidlange6 : This PR is a little time-critical, and introducing variable names for all these constants might take some time. Do you mind if we make another PR later implementing your suggestion?

[davidlange6]

@tanmaymudholkar - what would be the timescale for that PR? (roughly)

[tanmaymudholkar]

@davidlange6 - I believe the new PR should be ready in a couple of days.

[davidlange6]

+1
sounds good - thanks @tanmaymudholkar