Add HGCal to the geometries with Phase2 Tracker #14119

lgray · 2016-04-18T11:03:44Z

Adds HGCal to sim, LReco and dev steps.

Will rebase momentarily.

cmsbuild · 2016-04-18T11:06:48Z

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_1_X.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

lgray · 2016-04-18T11:17:44Z

@cmsbuild please test

cmsbuild · 2016-04-18T11:17:50Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12451/console

ianna · 2016-04-18T11:31:09Z

Geometry/CMSCommonData/python/cmsExtendedGeometry2023devXML_cfi.py

-        'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdblade8.xml',
-        'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdblade9.xml',
-        'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdblade10.xml',
+	'Geometry/TrackerCommonData/data/PhaseII/FlatTracker/pixfwdMaterials.xml',


@lgray and @boudoul - I think, an agreement was 2023sim is flat tracker and 2023dev is tilted tracker. Perhaps, it would be better to rename scenarios (2023Flat and 2023Tilted) to avoid such confusion in the future?

@ianna - I assumed this was a rebase issue that @lgray would take care of soon.

I personally would prefer to rename 2023dev to 2023tilted, but let's keep the standard 2023 with the flat tracker as just the "default" scenario. However, such renaming has to be propagated to the upgrade matrix workflows, so maybe we should hold off for this PR.

In general, we need a better way to organize the Phase2 variations. Right now tilted tracker is the only major case, but I'm sure there will be more to consider soon.

Can fix it but need to take care of other things first (HLT + PF related).
If you have time for a PR to this PR I'll merge it.

On Mon, Apr 18, 2016 at 1:33 PM, Kevin Pedro notifications@github.com
wrote:

In Geometry/CMSCommonData/python/cmsExtendedGeometry2023devXML_cfi.py
#14119 (comment):

'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdOuterDisk6.xml',

'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdOuterDisk7.xml',

'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdOuterDisk8.xml',

'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdOuterDisk9.xml',

'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdOuterDisk10.xml',

'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdblade1.xml',

'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdblade2.xml',

'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdblade3.xml',

'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdblade4.xml',

'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdblade5.xml',

'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdblade6.xml',

'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdblade7.xml',

'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdblade8.xml',

'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdblade9.xml',

'Geometry/TrackerCommonData/data/PhaseII/TiltedTracker/pixfwdblade10.xml',

'Geometry/TrackerCommonData/data/PhaseII/FlatTracker/pixfwdMaterials.xml',

@ianna https://github.com/ianna - I assumed this was a rebase issue
that @lgray https://github.com/lgray would take care of soon.

I personally would prefer to rename 2023dev to 2023tilted, but let's keep
the standard 2023 with the flat tracker as just the "default" scenario.
However, such renaming has to be propagated to the upgrade matrix
workflows, so maybe we should hold off for this PR.

In general, we need a better way to organize the Phase2 variations. Right
now tilted tracker is the only major case, but I'm sure there will be more
to consider soon.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/cms-sw/cmssw/pull/14119/files/e6885ff5bab026b1a39e746b3969ff0f6018d88c#r60043040

cmsbuild · 2016-04-18T12:15:01Z

+1
Tested at: e6885ff
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14119/12451/summary.html

ianna · 2016-04-18T12:19:00Z

-1

2023dev scenario is TiltedTracker

restore tilted tracker in 2023dev

kpedro88 · 2016-04-18T12:31:25Z

@ianna the tilted tracker is fixed now

cmsbuild · 2016-04-18T12:33:51Z

Pull request #14119 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

lgray · 2016-04-18T12:34:01Z

@cmsbuild please test

ianna · 2016-04-18T12:34:19Z

+1

cmsbuild · 2016-04-18T12:34:48Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12452/console

cmsbuild · 2016-04-18T12:34:48Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

kpedro88 · 2016-04-18T12:36:41Z

A few notes for posterity:

The needed fixes from 2023dev Scenario Fix #14053 are propagated to 2023simXML
Missing muon geometry cffs now imported in the relevant configs in Configuration/Geometry

cmsbuild · 2016-04-18T13:29:39Z

+1
Tested at: 007b5de
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14119/12452/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
007b5de
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14119/12452/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14119/12452/git-merge-result

cmsbuild · 2016-04-18T14:19:52Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14119/12452/summary.html

cmsbuild · 2016-04-18T14:45:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14119/12451/summary.html

cmsbuild · 2016-04-18T14:45:45Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14119/12451/summary.html

cmsbuild · 2016-04-18T15:15:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14119/12451/summary.html

davidlange6 · 2016-04-19T17:09:11Z

+1

cmsbuild added this to the Next CMSSW_8_1_X milestone Apr 18, 2016

cmsbuild added geometry-pending pending-signatures tests-pending orp-pending comparison-pending labels Apr 18, 2016

add HGCal to the geometries with Phase2 Tracker in them

e6885ff

lgray force-pushed the workflowsp2_81X_localreco branch from 5545e1d to e6885ff Compare April 18, 2016 11:17

cmsbuild added tests-started and removed tests-pending labels Apr 18, 2016

ianna reviewed Apr 18, 2016
View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Apr 18, 2016

cmsbuild added geometry-rejected and removed geometry-pending labels Apr 18, 2016

kpedro88 and others added 2 commits April 18, 2016 07:28

restore tilted tracker in 2023dev

edddc30

Merge pull request #22 from kpedro88/workflowsp2_81X_localreco

007b5de

restore tilted tracker in 2023dev

cmsbuild added geometry-pending tests-pending and removed geometry-rejected tests-approved labels Apr 18, 2016

cmsbuild added geometry-approved fully-signed and removed geometry-pending pending-signatures labels Apr 18, 2016

cmsbuild added tests-started and removed tests-pending labels Apr 18, 2016

cmsbuild added tests-approved and removed tests-started labels Apr 18, 2016

cmsbuild added comparison-available and removed comparison-pending labels Apr 18, 2016

cmsbuild added orp-approved and removed orp-pending labels Apr 19, 2016

cmsbuild merged commit e95e9f6 into cms-sw:CMSSW_8_1_X Apr 19, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add HGCal to the geometries with Phase2 Tracker #14119

Add HGCal to the geometries with Phase2 Tracker #14119

lgray commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

lgray commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

ianna Apr 18, 2016

kpedro88 Apr 18, 2016

lgray Apr 18, 2016

cmsbuild commented Apr 18, 2016

ianna commented Apr 18, 2016

kpedro88 commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

lgray commented Apr 18, 2016

ianna commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

kpedro88 commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

davidlange6 commented Apr 19, 2016

Add HGCal to the geometries with Phase2 Tracker #14119

Add HGCal to the geometries with Phase2 Tracker #14119

Conversation

lgray commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

lgray commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

ianna Apr 18, 2016

Choose a reason for hiding this comment

kpedro88 Apr 18, 2016

Choose a reason for hiding this comment

lgray Apr 18, 2016

Choose a reason for hiding this comment

cmsbuild commented Apr 18, 2016

ianna commented Apr 18, 2016

kpedro88 commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

lgray commented Apr 18, 2016

ianna commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

kpedro88 commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

cmsbuild commented Apr 18, 2016

davidlange6 commented Apr 19, 2016