Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uMNio data skipping implemented for urgent HLT patch #14158

Merged
merged 1 commit into from Apr 21, 2016

Conversation

Spudmeister
Copy link
Contributor

This patch to the HcalUnpacker.cc is needed for the HCAL laser operations in global

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Spudmeister for CMSSW_8_1_X.

It involves the following packages:

EventFilter/HcalRawToDigi

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor

For HLT online? Then we'd need a PR for 80X also!

@slava77
Copy link
Contributor

slava77 commented Apr 20, 2016

Some more details are needed with probably a link to a presentation (or/and an email with run coordination included with details and when this is needed).

@Spudmeister
Copy link
Contributor Author

I had intended this pull request to be for 8_0_X, as I based my changes on 8_0_X. Is there a way to choose what release the pull request is for?

@slava77
Copy link
Contributor

slava77 commented Apr 20, 2016

On 4/20/16 4:14 PM, Spudmeister wrote:

I had intended this pull request to be for 8_0_X, as I based my changes
on 8_0_X. Is there a way to choose what release the pull request is for?

target branch can not be changed after PR is created.
You will need to close one of the 81 PRs you made and create a new for 80X
There is a drop-down menu (or edit in the URL) of the target release
branch to be used before submission

@slava77
Copy link
Contributor

slava77 commented Apr 20, 2016

@cmsbuild please test

@Spudmeister what's the ETA for 80X PR?

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12526/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 20, 2016

+1

for #14158 9f195f4

  • HCAL unpacker to skip unpacking calibration laser PIN diode inputs coming in the same FED stream.
  • jenkins tests pass and comparisons with baseline show no difference (all inputs so far were apparently with getFormatVersion == 1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9d0f95d into cms-sw:CMSSW_8_1_X Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants