Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HGCal unit test to run with flat phase 2 tracker #14180

Merged
merged 1 commit into from
Apr 29, 2016
Merged

Update HGCal unit test to run with flat phase 2 tracker #14180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Configuration/StandardSequences/python/Eras.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def __init__(self):
# Scenarios further afield.
# Phase2 is everything for the 2023 (2026?) detector that works so far in this release.
# include phase 1 stuff until phase 2 tracking is fully defined....
self.Phase2 = cms.ModifierChain( self.phase1Pixel, self.trackingPhase1, self.phase2_common, self.phase2_tracker, self.phase2_hgcal, self.phase2_muon )
self.Phase2 = cms.ModifierChain( self.phase2_common, self.phase2_tracker, self.phase2_hgcal, self.phase2_muon )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's odd that the global era setup should be modified to get a unit test to work.
can this be something less invasive?
Say, add a Phase2_pixelLegacy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgray
@davidlange6
Does it make sense to edit here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put this there originally because no one had told me how the phase 2 tracker customization worked.
Now that I know how that's handled the phase1 stuff is no longer needed in general, not just for this unit test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slava77 Another way to fix this is to decommission this unit test and put HGCal tests into runTheMatrix or the addOn tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgray
I missed the context of phase1Pixel and trackingPhase1 added (in part also that it was added by you in part for this test to run). Thanks for pointing this out.
I'm not sure what's the best at this point: maybe phase1Pixel is still meaningful, but then trackingPhase1 doesn't make sense. So, removal should be OK.

@boudoul @makortel @ebrondol please confirm that

self.Phase2 = cms.ModifierChain( self.phase2_common, self.phase2_tracker, self.phase2_hgcal, self.phase2_muon )

is what's expected from tracker/tracking perspective

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about

runTheMatrix.py -l 11024

On Apr 26, 2016, at 3:41 PM, Lindsey Gray notifications@github.com wrote:

In Configuration/StandardSequences/python/Eras.py:

@@ -60,7 +60,7 @@ def init(self):
# Scenarios further afield.
# Phase2 is everything for the 2023 (2026?) detector that works so far in this release.
# include phase 1 stuff until phase 2 tracking is fully defined....

  •    self.Phase2 = cms.ModifierChain( self.phase1Pixel, self.trackingPhase1, self.phase2_common, self.phase2_tracker, self.phase2_hgcal, self.phase2_muon )

  •    self.Phase2 = cms.ModifierChain( self.phase2_common, self.phase2_tracker, self.phase2_hgcal, self.phase2_muon )

@slava77 Another way to fix this is to decommission this unit test and put HGCal tests into runTheMatrix or the addOn tests.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just tells that I know next to nothing about configuration of phase2_tracker.
Does the phase2TkFlat include the inner pixel tracker or is it just the outer phase2 tracker with the flat PS/2S module layout?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe phase2TkFlat and phase2TkTilted include all the customizations necessary for each version of the Phase2 tracker. The Phase1 customizations should not be necessary. @boudoul, can you confirm?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I can confirm that both cfg contain pixel and OT. The Phase1*.py are sometime useful to run the iterative tracking. I will get rid of them as soon as we will move phase2 to era (as mentioned also in PR#14240).

# Phase2dev is everything for the 2023 (2026?) detector that is still in development.
self.Phase2dev = cms.ModifierChain( self.Phase2, self.phase2dev_common, self.phase2dev_tracker, self.phase2dev_hgcal, self.phase2dev_muon )

Expand Down
9 changes: 5 additions & 4 deletions RecoLocalCalo/HGCalRecProducers/test/testHGCalRecoLocal_cfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import FWCore.ParameterSet.Config as cms
from Configuration.StandardSequences.Eras import eras

process = cms.Process("testHGCalRecoLocal",eras.Phase2,eras.phase1Pixel,eras.trackingPhase1)
process = cms.Process("testHGCalRecoLocal",eras.Phase2)

# import of standard configurations
process.load('Configuration.StandardSequences.Services_cff')
Expand All @@ -11,8 +11,8 @@
process.load('FWCore.MessageService.MessageLogger_cfi')
process.load('Configuration.EventContent.EventContent_cff')
process.load('SimGeneral.MixingModule.mixNoPU_cfi')
process.load('Configuration.Geometry.GeometryExtended2023DevReco_cff')
process.load('Configuration.Geometry.GeometryExtended2023Dev_cff')
process.load('Configuration.Geometry.GeometryExtended2023LRecoReco_cff')
process.load('Configuration.Geometry.GeometryExtended2023LReco_cff')
process.load('Configuration.StandardSequences.MagneticField_38T_PostLS1_cff')
process.load('Configuration.StandardSequences.Generator_cff')
process.load('IOMC.EventVertexGenerators.VtxSmearedGauss_cfi')
Expand Down Expand Up @@ -125,4 +125,5 @@
getattr(process,path)._seq = process.generator * getattr(process,path)._seq

# customisation of the process.

from SLHCUpgradeSimulations.Configuration.phase2TkFlat import customise
process=customise(process)