Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

80x Fireworks: Add checks for incomplete reco geometry #14196

Merged
merged 2 commits into from Apr 22, 2016
Merged

80x Fireworks: Add checks for incomplete reco geometry #14196

merged 2 commits into from Apr 22, 2016

Conversation

alja
Copy link
Contributor

@alja alja commented Apr 21, 2016

No description provided.

@alja
Copy link
Contributor Author

alja commented Apr 21, 2016

+1

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Apr 21, 2016
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12564/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_8_1_X.

It involves the following packages:

Fireworks/Core

@cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

+1
Tested at: b154049
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14196/12564/summary.html

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9aaec18 into cms-sw:CMSSW_8_1_X Apr 22, 2016
@alja alja deleted the slhc-geo-8x-shecks branch May 11, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed orp-approved tests-approved visualization-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alja @cmsbuild @davidlange6