Updated Phase2TrackerClusterizer validation code

[thomaslenzi]

Updated the Phase2Tracker Clusterizer validation code to use new class members of Phase2Tracker Digis and other new features of CMSSW 8.

[cmsbuild]

A new Pull Request was created by @thomaslenzi (Thomas Lenzi) for CMSSW_8_1_X.

It involves the following packages:

RecoLocalTracker/SiPhase2Clusterizer

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @gpetruc, @cerati, @threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[boudoul]

adding @delaere for information
@thomaslenzi , thanks for this PR.
For consistency , please change
process.load('Configuration.Geometry.GeometryExtended2023simReco_cff')
by
process.load('Configuration.Geometry.GeometryExtended2023LRecoReco_cff')
in RecoLocalTracker/SiPhase2Clusterizer/test/ClustersValidationTest_flat_cfg.py

[slava77]

Please move non-sim code to some other place.
Reco* subsystem should depend on the Sim minimally.

It's OK for validation code, but for the Phase2TrackerDigiCommon it doesn't seem justifiable, since the code just deals with TrackerTopology and DetId
SimTracker/SiPhase2Digitizer/src/Phase2TrackerDigiCommon.cc

[thomaslenzi]

Do I understand correctly that your comment is related to the file in SimTracker and not the ClusterValidation file ? If so, I cannot move this file but can copy/paste the code locally (which might not be the best solution).

[slava77]

@thomaslenzi
Yes, the comment was about somewhat improper location of Phase2TrackerDigiCommon.
If you are not the main developer there, please pass this along.
It doesn't have to be addressed with this PR, but better be, eventually.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12611/console

[cmsbuild]

Pull request #14225 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12614/console

[cmsbuild]

+1
Tested at: 4ec18fc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14225/12611/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14225/12611/summary.html

[cmsbuild]

+1
Tested at: e5c9e41
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14225/12614/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14225/12614/summary.html

[slava77]

+1

for #14225 e5c9e41

• essentially private test code changes updated in line with the description; the code/configuration is not running in central workflows.
• jenkins tests pass (compilation is enough)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1