Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr 14141 plus bxvector fix 80x #14246

Merged

Conversation

mulhearn
Copy link
Contributor

@mulhearn mulhearn commented Apr 26, 2016

This PR adds the BX vector fixes that caused IB RelVal failures in 81x.

@mulhearn
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Apr 26, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12634/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mulhearn for CMSSW_8_0_X.

It involves the following packages:

DataFormats/L1Trigger
EventFilter/L1TRawToDigi
EventFilter/L1TXRawToDigi
L1Trigger/Configuration
L1Trigger/L1TCaloLayer1
L1Trigger/L1TCalorimeter
L1Trigger/L1TCommon
L1Trigger/L1TGlobal
L1Trigger/L1TMuon
L1Trigger/L1TMuonBarrel
L1Trigger/L1TMuonEndCap

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@mulhearn could you rebase?..

@mulhearn
Copy link
Contributor Author

Sure, its just 3526ddd

…addition to fixing calling code, at protections to BXVector.
@mulhearn
Copy link
Contributor Author

This has been rebased.

@cmsbuild
Copy link
Contributor

Pull request #14246 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again.

@mulhearn
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12657/console

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14246/12657/summary.html

The workflows 134.911 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@davidlange6 davidlange6 merged commit 040cd8e into cms-sw:CMSSW_8_0_X Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants