Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plots vs. seeding layer set to MultiTrackValidator #14248

Merged
merged 3 commits into from May 4, 2016

Conversation

makortel
Copy link
Contributor

This PR adds number of tracks and fake/duplicate/pileup rates vs. seeding layer set (e.g. "BPix1+BPix2+BPix3"). The seeding layer set is deduced from the seed hits. In order to have necessary information to create the histograms with fixed binning, a list of all seeding layer sets is given as a configuration parameter. In the configuration side, the seeding layer sets of all seed producers (of a given sub-era) are merged by a new function.

Tested in 8_1_0_pre2, expecting only new histograms without changes in existing ones.

@rovere @VinInn

The seeding layer set is deduced from the seed hits. In order to have
necessary information to create the histograms with fixed binning, the
set of all seeding layers is given as a configuration parameter. In
the python configuration side, a function to merge the seeding layer
sets of all seed producers is added.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

RecoTracker/TkSeedingLayers
Validation/RecoTrack

@cvuosalo, @dmitrijus, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @wmtford, @gpetruc, @cerati, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@VinInn
Copy link
Contributor

VinInn commented Apr 26, 2016

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12636/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 27, 2016

+1

for #14248 3e70905

  • changes in reco are only in SeedingLayerSetsBuilder interface where previously private nameToEnumId and layerNamesInSets members are now made static
  • jenkins tests pass and comparisons with baseline show differences only in DQM (existing "Global efficiencies" histograms in tracking now have more bin entries, apparently to complement the additional detailed histograms).

@makortel
Copy link
Contributor Author

makortel commented May 3, 2016

Could DQM (@deguio @dmitrijus @vanbesien) please review and sign? Thanks.

@deguio
Copy link
Contributor

deguio commented May 4, 2016

+1
looks ok

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants