Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jet ID and b-tag information for Scouting Calojets #14271

Merged
merged 2 commits into from Apr 29, 2016
Merged

Jet ID and b-tag information for Scouting Calojets #14271

merged 2 commits into from Apr 29, 2016

Conversation

duanders
Copy link
Contributor

This PR modifies HLTScoutingCaloProducer so that it can put b-tag and jet ID information (provided as JetTagCollections) into ScoutingCaloJet objects.

The change does not modify the current behavior of this producer in the HLT menu. The new options (doJetBTags and doJetIDTags) are turned off by default.

This is related to the PR from @silviodonato (#14269), but the PRs can be merged independently of one another.

When this looks ok, I will submit a backport PR for 80X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @duanders (Dustin Anderson) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/Scouting
HLTrigger/JetMET

@perrotta, @smuzaffar, @cmsbuild, @Martin-Grunewald, @Dr15Jones, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 27, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12669/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1
Please make a PR for 80X.

@duanders
Copy link
Contributor Author

Thanks, backport to 80X is here: #14279

@Martin-Grunewald
Copy link
Contributor

Martin-Grunewald commented Apr 29, 2016

@Dr15Jones
Could you please sign this PR or comment otherwise?
Thanks!
Ah, ok, your comment is on #14279 - anyway....

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d702493 into cms-sw:CMSSW_8_1_X Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants