Quietly return when producer fails to find input collection #14283
Conversation
…s to find input collection. The scouting muon and Egamma producers were producing error manages when they could not find products not created by CaloScouting. Removed error messages. Immediately returns when collection is not found. Use unique_ptr instead of autoptr like b8366ba.
|
A new Pull Request was created by @davidsheffield (David Sheffield) for CMSSW_8_0_X. It involves the following packages: HLTrigger/Egamma @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
hlt-approved
fully-signed
and removed
hlt-pending
pending-signatures
labels
|
@davidlange6 |
|
+1 |
|
Sorry for not commenting earlier, but this doesn't seem like a sane approach...
Why do you consider it fine to not find the input collections ? |
|
@fwyzard - This PR standardizes the behavior that was implemented last year for the other scouting packer modules (#11627). The packers produce scouting objects from whatever HLT collections are available and don't complain if inputs are missing. Muon/electron collections can be missing in the PhysicsParkingScoutingMonitor stream when a "CaloScouting" trigger fires but no "PFScouting" trigger fires, because "CaloScouting" triggers don't produce muons/electrons. |
Backport of #14278
The scouting muon and Egamma producers were producing error manages when they could not find products not created by CaloScouting. Removed error messages. Immediately returns when collection is not found.
Use unique_ptr instead of auto_ptr like b8366ba.