Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to L1TCaloLayer1 and unpacker #14284

Merged
merged 25 commits into from May 3, 2016
Merged

Updates to L1TCaloLayer1 and unpacker #14284

merged 25 commits into from May 3, 2016

Conversation

nsmith-
Copy link
Contributor

@nsmith- nsmith- commented Apr 27, 2016

Contains:
Region validation
minBias unpacker updates
Code cleanup for emulator

nsmith- and others added 19 commits April 26, 2016 16:19
@nsmith-
Merged refs/pull/14141/head from repository cms-sw
1ef6549
@SridharaDasu @nsmith-
Additional bits for UCTRegion implemented
cbf7687
@SridharaDasu @nsmith-
Location fix for regions for comparisons with RCT
b636a3f
@SridharaDasu @nsmith-
Fixed region iEta,iPhi to match old RCT/GCT
6711471
@SridharaDasu @nsmith-
Added RCT region making
5b80853
@SridharaDasu @nsmith-
Region summary is 16 bits only - do the &
c212c5f
@SridharaDasu @nsmith-
Changed hit tower algorithm
85dbcf4
@SridharaDasu @nsmith-
Fixed UCTGeometry::getUCTTowerIndex
41db3fe
@SridharaDasu @nsmith-
Extended validator to do region validation
9fa2cba
@SridharaDasu @nsmith-
Changes to printouts for debugging
d99f492
@SridharaDasu @nsmith-
Implemented default HF bits without LUT usage
2e07d9b
@SridharaDasu @nsmith-
Emulator now passes both feature bits to Layer-2
0f80641
@SridharaDasu @nsmith-
Improved the hit tower location algorithm
290b444
@SridharaDasu @nsmith-
Improved hit tower position and code organization for it
9f3cb85
@nsmith-
Bits of cout cleanup and namespace fixes for CaloLayer1
7136fac
@nsmith-
Update CaloLayer1 unpacker for minBias HF feature bit
96f5e0c
@SridharaDasu @nsmith-
Added additional region checks
fbf9ed2
@nsmith-
L1 Calo emulator update for minBias
1142697 
Had to let the bits through
@nsmith-
Merge tag 'CMSSW_8_0_6' into l1tlayer1-dev-CMSSW_8_0_6
bf39746
@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Apr 27, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nsmith- (Nicholas Smith) for CMSSW_8_1_X.

It involves the following packages:

EventFilter/L1TXRawToDigi
L1Trigger/L1TCaloLayer1

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@nsmith- nsmith- mentioned this pull request Apr 27, 2016
Merged
@nsmith-
Copy link
Contributor Author

nsmith- commented Apr 27, 2016

I believe there was also some homework to do?
This is the PR to do it in, we are stable and Mike will not +1 without perfect bitwise agreement, so here is the chance to make (reasonable) code cleanup requests.

@nsmith- nsmith- mentioned this pull request Apr 27, 2016
Closed
@mulhearn
Copy link
Contributor

I'll try to test this later today...

@nsmith- nsmith- force-pushed the l1tlayer1-dev-CMSSW_8_0_6 branch from 95275c1 to 020e9d6 Compare May 2, 2016 13:48
@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

Pull request #14284 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again.

@mulhearn
Copy link
Contributor

mulhearn commented May 2, 2016

This passes our internal tests and does not change algorithm results.

@mulhearn
Copy link
Contributor

mulhearn commented May 2, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12765/console

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

+1
Tested at: 020e9d6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14284/12765/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14284/12765/summary.html

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ad0575f into cms-sw:CMSSW_8_1_X May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nsmith- @cmsbuild @mulhearn @davidlange6 @SridharaDasu