Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle the case where there are more than 10 streams #14304

Merged

Conversation

Dr15Jones
Copy link
Contributor

Previously log file parser only used the first character of the stream id when converting from a string to a number. This change makes sure to get all the digits.

Previously log file parser only used the first character of the stream id when converting from a string to a number. This change makes sure to get all the digits.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X.

It involves the following packages:

FWCore/Concurrency

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12726/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@Dr15Jones
Copy link
Contributor Author

@VinInn This fixes the problem where only 10 streams were being reported. Now it reports all 24 streams from your job.

@davidlange6 davidlange6 merged commit 9a96fe8 into cms-sw:CMSSW_8_1_X Apr 29, 2016
@cmsbuild
Copy link
Contributor

@Dr15Jones Dr15Jones deleted the handleManyStreamsInStallGrapher branch May 13, 2016 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants