Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to L1T packer needed to simultaneously pack GT inputs and GMT/Calo ouputs #14326

Merged
merged 5 commits into from May 2, 2016
Merged

Updates to L1T packer needed to simultaneously pack GT inputs and GMT/Calo ouputs #14326

merged 5 commits into from May 2, 2016

Conversation

mulhearn
Copy link
Contributor

@mulhearn mulhearn commented May 2, 2016

This is the 81x version of #14323.

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone May 2, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

A new Pull Request was created by @mulhearn for CMSSW_8_1_X.

It involves the following packages:

EventFilter/L1TRawToDigi
L1Trigger/Configuration
L1Trigger/L1TCommon

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mulhearn
Copy link
Contributor Author

mulhearn commented May 2, 2016

This PR passes internal L1T integration tests and bitwise reproduces L1T in CMSSW_806 (i.e. makes no change to L1T algorithms).

@mulhearn
Copy link
Contributor Author

mulhearn commented May 2, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12763/console

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@mulhearn mulhearn mentioned this pull request May 2, 2016
Closed
davidlange6
davidlange6 reviewed May 2, 2016
View reviewed changes
EventFilter/L1TRawToDigi/python/gtStage2Raw_cfi.py
@@ -4,7 +4,10 @@
"L1TDigiToRaw",
Setup = cms.string("stage2::GTSetup"),
# TowerInputLabel = cms.InputTag("simCaloStage2Digis"),
InputLabel = cms.InputTag("simGtStage2Digis"),
GtInputLabel = cms.InputTag("simGtStage2Digis"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mulhearn - these aren't available for data... whats the timescale for making the real digis?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mulhearn clariifies - its the digi->raw here..

@davidlange6 davidlange6 merged commit 5170952 into cms-sw:CMSSW_8_1_X May 2, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

+1
Tested at: f180f11
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14326/12763/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14326/12763/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed l1-approved orp-pending tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mulhearn @cmsbuild @davidlange6