New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimized CPU timing of ECAL Pi0 stream #14358
Conversation
A new Pull Request was created by @cippy for CMSSW_8_0_X. It involves the following packages: HLTrigger/special @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
81X PR needed as well! |
please test |
The tests are being triggered in jenkins. |
could you use |
@fwyzard It could be done, but it need to be validated. Some time needed. Could you first integrate this in the meantime? @Martin-Grunewald pull request for 8_1_X coming |
Please do. I don't think we need to push this online within the next couple of days anyway, right ? |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
…n() member function
Pull request #14358 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
@cippy thanks for the latest changes. .A |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Optimized CPU timing of ECAL Pi0 stream, following request in [0]. Changes affect HLTRegionalEcalResonanceFilter::calcPairCluster(...) method.
Tested on ZeroBias2016 dataset: CPU time reduced by a factor
[0] https://its.cern.ch/jira/browse/CMSHLT-741
@emanueledimarco @shervin86 @crovelli