Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimized CPU timing of ECAL Pi0 stream #14358

Merged
merged 4 commits into from May 11, 2016
Merged

Conversation

cippy
Copy link
Contributor

@cippy cippy commented May 3, 2016

Optimized CPU timing of ECAL Pi0 stream, following request in [0]. Changes affect HLTRegionalEcalResonanceFilter::calcPairCluster(...) method.
Tested on ZeroBias2016 dataset: CPU time reduced by a factor

  • ~ 30% in Barrel
  • ~ 50% in Endcap

[0] https://its.cern.ch/jira/browse/CMSHLT-741

@emanueledimarco @shervin86 @crovelli

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2016

A new Pull Request was created by @cippy for CMSSW_8_0_X.

It involves the following packages:

HLTrigger/special

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Martin-Grunewald
Copy link
Contributor

81X PR needed as well!

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12796/console

@fwyzard
Copy link
Contributor

fwyzard commented May 3, 2016

could you use math::XYZVector instead of TVector3 ?

@cippy
Copy link
Contributor Author

cippy commented May 3, 2016

@fwyzard It could be done, but it need to be validated. Some time needed. Could you first integrate this in the meantime?

@Martin-Grunewald pull request for 8_1_X coming

@fwyzard
Copy link
Contributor

fwyzard commented May 3, 2016

@fwyzard It could be done, but it need to be validated. Some time needed. Could you first integrate this in the meantime?

Please do. I don't think we need to push this online within the next couple of days anyway, right ?

@emanueledimarco
Copy link
Contributor

@fwyzard Right. If it is not so urgent, then @cippy can look at it.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2016

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2016

Pull request #14358 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12859/console

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2016

@fwyzard
Copy link
Contributor

fwyzard commented May 7, 2016

@cippy thanks for the latest changes.

.A

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ad2ba96 into cms-sw:CMSSW_8_0_X May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants