add track hit eff monitoring vs BX #14448

mtosi · 2016-05-11T09:53:10Z

back port of PR #14413
@rovere @VinInn @deguio

cmsbuild · 2016-05-11T09:53:31Z

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_0_X.

It involves the following packages:

DQM/TrackingMonitor
DQM/TrackingMonitorClient
DQM/TrackingMonitorSource

@cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

VinInn · 2016-05-11T09:53:54Z

@cmsbuild , please test

cmsbuild · 2016-05-11T09:54:12Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12911/console

cmsbuild · 2016-05-11T11:04:17Z

-1

Tested at: f3ac305

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14448/12911/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

10021.0 step3

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step3_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log

134.911 step3

runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2/step3_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

cmsbuild · 2016-05-11T11:23:53Z

Pull request #14448 was updated. @cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

mtosi · 2016-05-11T11:24:00Z

sorry
there was also DQM/TrackingMonitor/python/MonitorTrackGLBMuons_cfi.py to be modified
runTheMatrix -l limited is giving
10 10 9 7 5 1 1 tests passed, 0 0 0 0 0 0 0 failed
now

dmitrijus · 2016-05-11T12:03:22Z

Then backporting, the easiest way to do it:

scram p <cmssw_release>
git-cms-addpkg ...

and then, if pull has been merged, do:
git cherry-pick -x <commit id> for every pull commit in pull request

for your PR, that would be:

git cherry-pick -x  cbd338fef81c03ba5b1f20fae31c968eb83ee564
git cherry-pick -x  f7de06e42add53c2977e75941614a59738aaef91
git cherry-pick -x  7b3e7d87529be1f4c302d6aa1c74dad206ab6505

This way the changes in this backport are exactly the same as in the merged PR.
And it helps to avoid mistakes such as above :)

It is also possible to create commits, which can be merged into both 80x and 81x at the same time (using merge-base), but it's a bit too complicated to explain.

VinInn · 2016-05-13T11:45:00Z

@cmsbuild , please test

cmsbuild · 2016-05-13T11:46:32Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12971/console

cmsbuild · 2016-05-13T14:25:38Z

+1
Tested at: 9d827ad
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14448/12971/summary.html

cmsbuild · 2016-05-13T17:28:32Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14448/12971/summary.html

cmsbuild · 2016-05-24T15:41:35Z

Pull request #14448 was updated. @cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

VinInn · 2016-05-24T15:42:56Z

@cmsbuild , please test

cmsbuild · 2016-05-24T15:43:14Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13162/console

cmsbuild · 2016-05-24T15:58:10Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14448/13155/summary.html

cmsbuild · 2016-05-24T17:18:57Z

+1
Tested at: e0d4c74
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14448/13162/summary.html

cmsbuild · 2016-05-24T18:19:27Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14448/13162/summary.html

dmitrijus · 2016-05-30T14:10:17Z

+1

cmsbuild · 2016-05-30T14:10:38Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 · 2016-05-31T15:30:45Z

+1

add hit eff monitoring vs BX

f3ac305

cmsbuild added this to the Next CMSSW_8_0_X milestone May 11, 2016

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending comparison-pending labels May 11, 2016

mtosi mentioned this pull request May 11, 2016

add track hit eff monitoring vs BX #14413

Merged

cmsbuild added tests-started and removed tests-pending labels May 11, 2016

cmsbuild added tests-rejected and removed tests-started labels May 11, 2016

fix MonitorTrackGLBMuons_cfi.py

9d827ad

cmsbuild added tests-pending and removed tests-rejected labels May 11, 2016

cmsbuild added tests-started and removed tests-pending labels May 13, 2016

cmsbuild added tests-approved and removed tests-started labels May 13, 2016

fix y-axis title

e0d4c74

cmsbuild added tests-pending and removed tests-approved labels May 24, 2016

cmsbuild added tests-started and removed tests-pending labels May 24, 2016

cmsbuild added comparison-available and removed comparison-pending labels May 24, 2016

cmsbuild added tests-approved comparison-pending and removed comparison-available tests-started labels May 24, 2016

cmsbuild added comparison-available and removed comparison-pending labels May 24, 2016

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 30, 2016

mtosi mentioned this pull request May 31, 2016

fix tracking DQM client config #14614

Merged

cmsbuild added orp-approved and removed orp-pending labels May 31, 2016

cmsbuild merged commit d74708f into cms-sw:CMSSW_8_0_X May 31, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add track hit eff monitoring vs BX #14448

add track hit eff monitoring vs BX #14448

mtosi commented May 11, 2016

cmsbuild commented May 11, 2016

VinInn commented May 11, 2016

cmsbuild commented May 11, 2016 •

edited

cmsbuild commented May 11, 2016

cmsbuild commented May 11, 2016

mtosi commented May 11, 2016 •

edited

dmitrijus commented May 11, 2016 •

edited

VinInn commented May 13, 2016

cmsbuild commented May 13, 2016 •

edited

cmsbuild commented May 13, 2016

cmsbuild commented May 13, 2016

cmsbuild commented May 24, 2016

VinInn commented May 24, 2016

cmsbuild commented May 24, 2016 •

edited

cmsbuild commented May 24, 2016

cmsbuild commented May 24, 2016

cmsbuild commented May 24, 2016

dmitrijus commented May 30, 2016

cmsbuild commented May 30, 2016

davidlange6 commented May 31, 2016

add track hit eff monitoring vs BX #14448

add track hit eff monitoring vs BX #14448

Conversation

mtosi commented May 11, 2016

cmsbuild commented May 11, 2016

VinInn commented May 11, 2016

cmsbuild commented May 11, 2016 • edited

cmsbuild commented May 11, 2016

cmsbuild commented May 11, 2016

mtosi commented May 11, 2016 • edited

dmitrijus commented May 11, 2016 • edited

VinInn commented May 13, 2016

cmsbuild commented May 13, 2016 • edited

cmsbuild commented May 13, 2016

cmsbuild commented May 13, 2016

cmsbuild commented May 24, 2016

VinInn commented May 24, 2016

cmsbuild commented May 24, 2016 • edited

cmsbuild commented May 24, 2016

cmsbuild commented May 24, 2016

cmsbuild commented May 24, 2016

dmitrijus commented May 30, 2016

cmsbuild commented May 30, 2016

davidlange6 commented May 31, 2016

cmsbuild commented May 11, 2016 •

edited

mtosi commented May 11, 2016 •

edited

dmitrijus commented May 11, 2016 •

edited

cmsbuild commented May 13, 2016 •

edited

cmsbuild commented May 24, 2016 •

edited