Monitor CASTOR table data (80X)

[kpedro88]

This PR adds some functionality to unpack data from the CASTOR table, currently being used for HCAL radiation studies. The HcalCalibDetId is repurposed to store the necessary information about each channel. These new features should not interfere with any existing workflow. We request expedited review/approval so we can start using this online ASAP. This PR was backported from 81X.

attn: @jmmans, @Spudmeister, @bsunanda, @abdoulline, @vkhristenko

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_0_X.

It involves the following packages:

CalibFormats/HcalObjects
DataFormats/HcalDetId
DataFormats/HcalDigi
EventFilter/HcalRawToDigi

@ghellwig, @civanch, @cvuosalo, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @slava77, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ghellwig, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[kpedro88]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12926/console

[cmsbuild]

+1
Tested at: fe633a2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14462/12926/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14462/12926/summary.html

[cmsbuild]

Pull request #14462 was updated. @ghellwig, @civanch, @cvuosalo, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @slava77, @mmusich, @davidlange6 can you please check and sign again.

[kpedro88]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13123/console

[cmsbuild]

+1
Tested at: ffca551
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14462/13123/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14462/13123/summary.html

[civanch]

+1

[mmusich]

+1

[slava77]

+1

for #14462 ffca551

• since the last signoff , the only update is the same as the bugfix in 81X version Fix QIE11 unpacking bug #14599 40d94b9. There is no effect on channels used for physics at this point.
• jenkins tests pass and comparisons with baseline show no differences
• see Fix QIE11 unpacking bug #14599 for some details of testing on 2016 data including that with QIE11 channels

@davidlange6 this was requested by HCAL for 809 earlier
[hopefully there are no more bugfixes at the rate they were coming since the initial submission of this PR]

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[abdoulline]

Indeed, there were 4 rounds (well above average...) of updates/fixes.
No more changes expected. And HCAL management (Pawel De Barbaro) asks for
incluson of it in the next data-taking release.
We have already an updated emap tag which will be submitted to AlCa for
validation immediately after the release will be cut.

On Tue, 24 May 2016, Slava Krutelyov wrote:

+1

for #14462 ffca551

• since the last signoff , the only update is the same as the bugfix in 81X version Fix QIE11 unpacking bug #14599 40d94b9. There
  is no effect on channels used for physics at this point.
• jenkins tests pass and comparisons with baseline show no differences
• see Fix QIE11 unpacking bug #14599 for some details of testing on 2016 data including that with QIE11 channels

@davidlange6 this was requested by HCAL for 809 earlier
[hopefully there are no more bugfixes at the rate they were coming since the initial submission of this PR]

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub[AEx02lL56aJEtIGCuDdCGSYr3-ApVNigks5qE2j5gaJpZM4IcbqN.gif]

[kpedro88]

@davidlange6 just a reminder to merge this for 8_0_9 if possible... #14599 has been in 4 IBs now and does not seem to have broken anything.

[davidlange6]

+1