Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix det search tolerances for Cosmics #14466

Merged
merged 1 commit into from May 13, 2016
Merged

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented May 12, 2016

the title says all

@VinInn
Copy link
Contributor Author

VinInn commented May 12, 2016

@cmsbuild , please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone May 12, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented May 12, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12930/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_8_1_X.

It involves the following packages:

RecoTracker/CkfPattern
TrackingTools/DetLayers

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @mschrode, @gpetruc, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@VinInn - just to clarify - I had understood the missing rate issue was limited to B=0 - does this PR also have a significant effect at B=3.8?

@VinInn
Copy link
Contributor Author

VinInn commented May 12, 2016

We do not know the effect at 3.8T.
In any case it is consistent with what used elsewhere for instance for Muon seeded, conversion, electron etc
I asked Matti to use it also for LowPU.
Essentially makes it consistent with RunI and 7X

@slava77
Copy link
Contributor

slava77 commented May 13, 2016

+1

for #14466 750f907

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 772b226 into cms-sw:CMSSW_8_1_X May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants