Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relval matrix update #14469

Merged
merged 8 commits into from May 18, 2016
Merged

Conversation

hengne
Copy link
Contributor

@hengne hengne commented May 12, 2016

Updates include:

  • minibias for mixing/premixing inputs
  • turn on EI and PAT steps in upgrade 2017 workflows

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hengne (Hengne Li) for CMSSW_8_1_X.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@hengne
Copy link
Contributor Author

hengne commented May 12, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 12, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12937/console

@makortel
Copy link
Contributor

For completeness, should the MiniAOD DQM and validation sequences and MiniAOD output file be added too to 2017 workflows now?

@hengne
Copy link
Contributor Author

hengne commented May 12, 2016

@makortel thanks, definitely, sorry that i should actually think of this point in advance... will update this PR after some local test.

@cmsbuild
Copy link
Contributor

@hengne
Copy link
Contributor Author

hengne commented May 12, 2016

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @hengne
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label May 12, 2016
@hengne
Copy link
Contributor Author

hengne commented May 12, 2016

unhold

@hengne
Copy link
Contributor Author

hengne commented May 12, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 12, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12953/console

@cmsbuild
Copy link
Contributor

Pull request #14469 was updated. @cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please check and sign again.

@cmsbuild
Copy link
Contributor

@hengne
Copy link
Contributor Author

hengne commented May 12, 2016

@makortel done.

@hengne
Copy link
Contributor Author

hengne commented May 12, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@hengne
Copy link
Contributor Author

hengne commented May 17, 2016

@davidlange6 I think it would be good to have this PR merged for building the 810pre5. for this i sent you and @slava77 an email a couple of days ago with name "Re: 2017 PR tests?", but maybe that didn't catch your attention. What can be an alternative for this? It would be good to have the EI and PAT steps in 2017 workflows and they are tested to be working fine.
p.s. sorry i couldn't join the ORP meeting this afternoon for some family things.

@davidlange6
Copy link
Contributor

+1

for the record this also turns on HLT , PAT, EI for the phase 2 workflows. Seems ok at this point, but may eventually cause problems.

@cmsbuild cmsbuild merged commit 1c7dee8 into cms-sw:CMSSW_8_1_X May 18, 2016
@hengne
Copy link
Contributor Author

hengne commented May 18, 2016

@davidlange6 Thanks! so far local tests are all ok (in sense of running without crash), i have submitted the relval 2017 workflows with these changes with pre5, will see the results soon with higher statistics.

@slava77
Copy link
Contributor

slava77 commented May 18, 2016

@hengne
is wf 11024 still running after your change?

@hengne
Copy link
Contributor Author

hengne commented May 18, 2016

@slava77 I have tested wf 11024, it works fine.

Together with 11024, all the 2023 scenarios which are using the updated "DigiFull" step (HLT:@Fake added) have been tested. The results summarized below:

10424: '2023'
=> fail at the GENSIM step before going to the Digi step, due to missing cust_2023 function:
Exception: config SLHCUpgradeSimulations/Configuration/combinedCustoms has no function cust_2023

10624: '2023tilted'
=> Pass all steps

11024: '2023LReco'
=> Pass all steps

11224: '2023Reco'
=> fail at the GENSIM step before going to the Digi step, due to missing cust_2023Reco function:
Exception: config SLHCUpgradeSimulations/Configuration/combinedCustoms has no function cust_2023Reco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants