Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed non-const static for EventFilter/EcalRawToDigi #1448

Merged

Conversation

nclopezo
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nclopezo (David Mendez) for CMSSW_7_0_X.

Fixed non-const static for EventFilter/EcalRawToDigi

It involves the following packages:

EventFilter/EcalRawToDigi

@nclopezo, @cmsbuild, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor

What about this class static? static stats_t stats_init;

@nclopezo
Copy link
Contributor Author

Sorry, I missed that one, I updated my pull request.

@cmsbuild
Copy link
Contributor

Pull request #1448 was updated. @nclopezo, @cmsbuild, @thspeer, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@thspeer
Copy link
Contributor

thspeer commented Nov 14, 2013

+1
tested e61ef94 in CMSSW_7_0_X_2013-11-13-0200-1448
No difference in reco as expected, based on RelMon and reco script

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 14, 2013
…ToDigi

Multithreading fixes -- Fixed non-const static for EventFilter/EcalRawToDigi
@ktf ktf merged commit c820bfe into cms-sw:CMSSW_7_0_X Nov 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants