Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numeric header include for std::accumulate to fix gcc600 error #14504

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented May 14, 2016

recent builds in gcc 600 are failing with

RecoTracker/TkSeedGenerator/src/FastCircleFit.cc:56:34: error: 'accumulate' is not a member of 'std'
    const float invTotWeight = 1.f/std::accumulate(weight.begin(), weight.end(), 0.f);
                                  ^~~

added #include <numeric> to resolve the issue.
Afrer rebuilding RecoTracker/TkSeedGenerator and all other packages that failed linking in CMSSW_8_1_X_2016-05-13-2300 the cmsRun is functional again.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_1_X.

It involves the following packages:

RecoTracker/TkSeedGenerator

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@davidlt
Copy link
Contributor

davidlt commented May 14, 2016

Yeah, I need to re-bootstrap GCC 6 branch. I will do that for the next week then it should be back and working.

@slava77
Copy link
Contributor Author

slava77 commented May 14, 2016

@cmsbuild please test
@davidlt please clarify: is this PR useful?

@cmsbuild
Copy link
Contributor

cmsbuild commented May 14, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12989/console

@davidlt
Copy link
Contributor

davidlt commented May 14, 2016

@slava77 it's useful.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor Author

slava77 commented May 15, 2016

+1

for #14504 214dae3

  • jenkins tests pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9b27f7e into cms-sw:CMSSW_8_1_X May 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants