Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo correction in config file #14539

Merged
merged 1 commit into from
Sep 7, 2016
Merged

Conversation

lathomas
Copy link
Contributor

Similar PR as for 81X: #14538
This is a 1 line correction.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lathomas for CMSSW_8_0_X.

It involves the following packages:

RecoMET/METProducers

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented May 17, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13028/console

@slava77
Copy link
Contributor

slava77 commented May 17, 2016

I think that the earliest this can be added is when we want/need to change to a new 2016 acquisition era (2016C).
@davidlange6 is there going to be an update after/during TS1?

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented May 20, 2016

+1

for #14539 d82f2e2

  • change muon selection cut to reduce mistag rate; the same code change as in 81X version
  • jenkins tests pass and show some changes in CSC halo ID variables

this will be put on hold until there is a good time to integrate in 80X

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@slava77
Copy link
Contributor

slava77 commented May 20, 2016

hold

until there is a good time to integrate in 80X, since this is a behavior change, but this code is a special case, affecting only data (MC production has a bad/old version)

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @slava77
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@davidlange6 davidlange6 merged commit a3a5451 into cms-sw:CMSSW_8_0_X Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants