New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of histograms for TauPOG DQM data certification for future data taking #14549
Update of histograms for TauPOG DQM data certification for future data taking #14549
Conversation
integration of new plots and clean up of Tau DQM code: I still have a bunch of open items and questions here, but I'm closing this PR at this point to finally get it going. I can do the required changes myself...
A new Pull Request was created by @roger-wolf (Roger Wolf) for CMSSW_8_1_X. It involves the following packages: Validation/RecoTau @cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test @dmitrijus this has been awaiting review for a few days already |
The tests are being triggered in jenkins. |
Comparison is ready The workflows 1003.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
can you let me know what is missing to get this pull request off the table. We are missing your signature since two weeks now. I think it's the last missing piece in the chain. Thanx a lot! |
please test Nothing is missing, should be okay. |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
This is an update of histograms for TauPOG data certification for future data taking. The pull request is minimal in this sense. We have checked theMatrix and our standard s/w validation sequences to make sure that the changes do not interfere in any way. Our tests were positive. The pull request goes along with a similar request for the DQM GUI that according to our developer (@atanumodak) has already been accepted and integrated.