Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of histograms for TauPOG DQM data certification for future data taking #14549

Conversation

roger-wolf
Copy link
Contributor

This is an update of histograms for TauPOG data certification for future data taking. The pull request is minimal in this sense. We have checked theMatrix and our standard s/w validation sequences to make sure that the changes do not interfere in any way. Our tests were positive. The pull request goes along with a similar request for the DQM GUI that according to our developer (@atanumodak) has already been accepted and integrated.

atanumodak and others added 3 commits April 20, 2016 14:01
integration of new plots and clean up of Tau DQM code: I still have a bunch of open items and questions here, but I'm closing this PR at this point to finally get it going. I can do the required changes myself...
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @roger-wolf (Roger Wolf) for CMSSW_8_1_X.

It involves the following packages:

Validation/RecoTau

@cmsbuild, @dmitrijus, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented May 25, 2016

@cmsbuild please test

@dmitrijus this has been awaiting review for a few days already

@cmsbuild
Copy link
Contributor

cmsbuild commented May 25, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13204/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14549/13204/summary.html

The workflows 1003.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@roger-wolf
Copy link
Contributor Author

@dmitrijus

can you let me know what is missing to get this pull request off the table. We are missing your signature since two weeks now. I think it's the last missing piece in the chain.

Thanx a lot!
Roger

@dmitrijus
Copy link
Contributor

please test

Nothing is missing, should be okay.
I must have missed this PR :(

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13396/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

@davidlange6
Copy link
Contributor

+1
@roger-wolf - if this is really meant for data certification, the heart of the code should move out of Validation/* (MC validation) and into DQM(Offline).

@cmsbuild cmsbuild merged commit 09e7a10 into cms-sw:CMSSW_8_1_X Jun 7, 2016
@roger-wolf roger-wolf deleted the CMSSW_8_1_X_tau-pog_DQM-data-certification branch August 8, 2016 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants