Update vertex validation #14663
Update vertex validation #14663
Conversation
This way I can use another analyzer instance to produce the plots for pixelVertices, and avoid filling the generic sim plots twice.
More details include pixelVertices and firsStepPrimaryVertices for those tracking configurations that have them.
|
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X. It involves the following packages: Validation/Configuration @civanch, @cvuosalo, @mdhildreth, @dmitrijus, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild , please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
+1 |
|
@makortel it's on the list |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
| const double minLog10 = std::log10(min); | ||
| const double maxLog10 = std::log10(max); | ||
| const double width = (maxLog10-minLog10)/N; | ||
| std::array<T, N+1> ret; |
There was a problem hiding this comment.
@makortel for a future PR, this would be more efficiently written as
ret[0]=std::pow(10,minLog10);
const double mult=std::pow(10, (maxLog10-minLog10)/N);
for ( size_t i=1; i<=N; ++i) ret[i]=ret[i-1]*mult;
There was a problem hiding this comment.
Thanks, I'll take a note (even though the function is called only once from bookHistograms()).
|
+1 |
This PR provides following updates to the vertex validation package
Tested in CMSSW_8_1_0_pre4, no changes expected in existing histograms (there may appear small numerical differences in
*_Meanand*_Sigmahistograms produced byDQMGenericClient, but the source histograms for those should be equal).@rovere @VinInn