Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup RawToDigi redefinition of already loaded from RawToDigi_cff #14675

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented May 28, 2016

remove overriding RawToDigi definition for data configs

This could have been done in 2011 (rev 1.15)
https://cvs.web.cern.ch/cvs/cgi-bin/viewcvs.cgi/CMSSW/Configuration/StandardSequences/python/RawToDigi_Data_cff.py
when RawToDigi_cff was added back to this file via import.

Currently this prevents transparent updates and use of eras (discovered/realised while integrating CTPPS code).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_1_X.

It involves the following packages:

Configuration/StandardSequences

@cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor Author

slava77 commented May 28, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13243/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor Author

slava77 commented May 28, 2016

jenkins tests run and show no differences, as expected

davidlange6 added a commit that referenced this pull request May 29, 2016
…anupRawToDigi_Data

cleanup RawToDigi redefinition of already loaded from RawToDigi_cff (bp of #14675)
@davidlange6 davidlange6 merged commit e1cd7a3 into cms-sw:CMSSW_8_1_X May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants