tracking and strip DQM : trigger selection via DB + stage2 L1 handling in GenericTriggerEventFlag #14693

mtosi · 2016-05-31T07:13:36Z

it was PR #14660
I thought to have already fixed the conflict, but it did not work
now, it should be ok (cross the fingers)

cmsbuild · 2016-05-31T07:13:55Z

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_0_X.

It involves the following packages:

CommonTools/TriggerUtils
DQM/SiStripMonitorClient
DQM/SiStripMonitorTrack
DQM/TrackerMonitorTrack
DQM/TrackingMonitor
DQM/TrackingMonitorSource

@cvuosalo, @dmitrijus, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @threus, @venturia this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

slava77 · 2016-05-31T12:36:13Z

@cmsbuild please test

cmsbuild · 2016-05-31T12:36:32Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13277/console

cmsbuild · 2016-05-31T14:03:51Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2016-05-31T14:04:27Z

-1

Tested at: 72ae4b6

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
bc82047
0bf418a
d4a4144
ba46a23
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14693/13277/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14693/13277/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14693/13277/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/DQM/Physics/src/SingleTopTChannelLeptonDQM_miniAOD.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/DQM/Physics/src/TopSingleLeptonDQM.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/DQM/Physics/src/B2GDQM.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/DQM/Physics/src/TopSingleLeptonDQM_miniAOD.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/CommonTools/TriggerUtils/src/GenericTriggerEventFlag.cc: In member function 'void GenericTriggerEventFlag::initRun(const edm::Run&, const edm::EventSetup&)':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/CommonTools/TriggerUtils/src/GenericTriggerEventFlag.cc:182:15: error: 'class l1t::L1TGlobalUtil' has no member named 'retrieveL1Run'
       l1uGt_->retrieveL1Run(setup);
               ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/CommonTools/TriggerUtils/src/GenericTriggerEventFlag.cc:184:15: error: 'class l1t::L1TGlobalUtil' has no member named 'retrieveL1LumiBlock'
       l1uGt_->retrieveL1LumiBlock(setup);
               ^

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_0_X_2016-05-29-0000/src/CondCore/CondDB/interface/PayloadReader.h:2:9: note: 'CondCore_CondDB_PyloadReader_h' is defined here; did you mean 'CondCore_CondDB_PayloadReader_h'?
#define CondCore_CondDB_PyloadReader_h
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        CondCore_CondDB_PayloadReader_h
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/CommonTools/TriggerUtils/src/GenericTriggerEventFlag.cc:6:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/CommonTools/TriggerUtils/interface/GenericTriggerEventFlag.h:157:24: error: calling a private constructor of class 'l1t::L1TGlobalUtil'
      l1uGt_.reset(new l1t::L1TGlobalUtil());
                       ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-05-29-0000/src/L1Trigger/L1TGlobal/interface/L1TGlobalUtil.h:161:5: note: declared private here
    L1TGlobalUtil();
    ^

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
bc82047
0bf418a
d4a4144
ba46a23
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14693/13277/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14693/13277/git-merge-result

cmsbuild · 2016-06-01T08:55:45Z

Pull request #14693 was updated. @cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

cmsbuild · 2016-06-01T08:58:34Z

Pull request #14693 was updated. @cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

cmsbuild · 2016-06-01T09:01:25Z

Pull request #14693 was updated. @cvuosalo, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

mtosi · 2016-06-01T09:05:05Z

runTheMatrix.py -l limited -i all
10 10 9 7 5 1 1 tests passed, 0 0 0 0 0 0 0 failed

mmusich · 2016-06-01T09:46:28Z

please test

cmsbuild · 2016-06-01T09:47:07Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13301/console

slava77 · 2016-06-16T17:34:07Z

@cmsbuild please test
.. will retry until it works or until the errors repeat

cmsbuild · 2016-06-16T17:34:28Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13564/console

cmsbuild · 2016-06-16T20:33:36Z

+1
Tested at: 621020f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14693/13564/summary.html

cmsbuild · 2016-06-16T21:44:31Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14693/13564/summary.html

slava77 · 2016-06-16T22:50:15Z

+1

for #14693 621020f

backport of changes made in 81X equivalent to tracking and strip DQM : trigger selection via DB + stage2 L1 handling in GenericTriggerEventFlag + update the trigger bits for Tracker DQM #14820 10da65f, the only differences wrt 81X change are in the autoCond.py as needed for 80X
jenkins tests pass and comparisons with baseline show no differences in reco products; there are differences in tracker validation plots in the same way as in tracking and strip DQM : trigger selection via DB + stage2 L1 handling in GenericTriggerEventFlag + update the trigger bits for Tracker DQM #14820

mmusich · 2016-06-17T06:53:55Z

+1
@franzoni @mtosi @boudoul @fioriNTU
Note to selves: once this PR is merged and included in a release, eventually deployed at Tier-0, it is mandatory to update the AlCaRecoTriggerBitsRcd in the Express and Prompt Global Tags through append-IOV or better yet a new tag, to keep the offline DQM plots filled in the correct way.

mtosi · 2016-06-17T07:21:16Z

thanks much @mmusich !
could arun setup the needed updated ?

mmusich · 2016-06-17T07:27:46Z

you'll have to choose what to use as paths in there, and instruct him to create the payloads.

dmitrijus · 2016-06-20T13:01:32Z

DQM/TrackingMonitor/src/dEdxAnalyzer.cc

@@ -25,7 +25,7 @@ dEdxAnalyzer::dEdxAnalyzer(const edm::ParameterSet& iConfig)
  , conf_    (fullconf_.getParameter<edm::ParameterSet>("dEdxParameters") )
  , doAllPlots_  ( conf_.getParameter<bool>("doAllPlots") )
  , doDeDxPlots_ ( conf_.getParameter<bool>("doDeDxPlots") )    
-  , genTriggerEventFlag_( new GenericTriggerEventFlag(conf_,consumesCollector(), *this) )
+  , genTriggerEventFlag_( new GenericTriggerEventFlag(conf_.getParameter<edm::ParameterSet>("genericTriggerEventPSet"),consumesCollector(), *this) )


Perhaps, it would make more sense if genTriggerEventFlag_ was a unique_ptr?
I don't mind it either way, you have a proper destructor.

In principle genTriggerEventFlag_ could be made a regular member too (or, by quick look I don't see any specific reason why it should be a pointer), which would simplify the construction/destruction side even more.

dmitrijus · 2016-06-20T13:01:44Z

+1

mtosi · 2016-06-29T09:02:42Z

could this PR be integrated, please ?

cmsbuild added this to the Next CMSSW_8_0_X milestone May 31, 2016

cmsbuild added reconstruction-pending dqm-pending analysis-pending pending-signatures tests-pending orp-pending comparison-pending labels May 31, 2016

mtosi mentioned this pull request May 31, 2016

tracking and strip DQM : trigger selection via DB + stage2 L1 handling in GenericTriggerEventFlag #14660

Closed

cmsbuild added tests-started and removed tests-pending labels May 31, 2016

cmsbuild added comparison-notrun and removed comparison-pending labels May 31, 2016

cmsbuild added tests-rejected comparison-pending tests-pending and removed comparison-notrun tests-started tests-rejected labels May 31, 2016

cmsbuild added tests-rejected comparison-pending and removed tests-started labels Jun 16, 2016

cmsbuild added tests-pending tests-started and removed tests-rejected tests-pending labels Jun 16, 2016

cmsbuild added tests-approved and removed tests-started labels Jun 16, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jun 16, 2016

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jun 16, 2016

cmsbuild added alca-approved and removed alca-pending labels Jun 17, 2016

dmitrijus reviewed Jun 20, 2016
View reviewed changes

cmsbuild added dqm-approved and removed dqm-pending labels Jun 20, 2016

davidlange6 merged commit 1a48554 into cms-sw:CMSSW_8_0_X Jul 5, 2016

degrutto mentioned this pull request Sep 2, 2016

migration to 8_0_17 including fix for btag calibrator and BTV mitigation recipe vhbb/cmssw#537

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tracking and strip DQM : trigger selection via DB + stage2 L1 handling in GenericTriggerEventFlag #14693

tracking and strip DQM : trigger selection via DB + stage2 L1 handling in GenericTriggerEventFlag #14693

mtosi commented May 31, 2016

cmsbuild commented May 31, 2016

slava77 commented May 31, 2016

cmsbuild commented May 31, 2016 •

edited

cmsbuild commented May 31, 2016

cmsbuild commented May 31, 2016

cmsbuild commented Jun 1, 2016

cmsbuild commented Jun 1, 2016

cmsbuild commented Jun 1, 2016

mtosi commented Jun 1, 2016

mmusich commented Jun 1, 2016

cmsbuild commented Jun 1, 2016 •

edited

slava77 commented Jun 16, 2016

cmsbuild commented Jun 16, 2016 •

edited

cmsbuild commented Jun 16, 2016

cmsbuild commented Jun 16, 2016

slava77 commented Jun 16, 2016

mmusich commented Jun 17, 2016 •

edited

mtosi commented Jun 17, 2016

mmusich commented Jun 17, 2016

dmitrijus Jun 20, 2016

makortel Jun 20, 2016

dmitrijus commented Jun 20, 2016

mtosi commented Jun 29, 2016

tracking and strip DQM : trigger selection via DB + stage2 L1 handling in GenericTriggerEventFlag #14693

tracking and strip DQM : trigger selection via DB + stage2 L1 handling in GenericTriggerEventFlag #14693

Conversation

mtosi commented May 31, 2016

cmsbuild commented May 31, 2016

slava77 commented May 31, 2016

cmsbuild commented May 31, 2016 • edited

cmsbuild commented May 31, 2016

cmsbuild commented May 31, 2016

cmsbuild commented Jun 1, 2016

cmsbuild commented Jun 1, 2016

cmsbuild commented Jun 1, 2016

mtosi commented Jun 1, 2016

mmusich commented Jun 1, 2016

cmsbuild commented Jun 1, 2016 • edited

slava77 commented Jun 16, 2016

cmsbuild commented Jun 16, 2016 • edited

cmsbuild commented Jun 16, 2016

cmsbuild commented Jun 16, 2016

slava77 commented Jun 16, 2016

mmusich commented Jun 17, 2016 • edited

mtosi commented Jun 17, 2016

mmusich commented Jun 17, 2016

dmitrijus Jun 20, 2016

Choose a reason for hiding this comment

makortel Jun 20, 2016

Choose a reason for hiding this comment

dmitrijus commented Jun 20, 2016

mtosi commented Jun 29, 2016

cmsbuild commented May 31, 2016 •

edited

cmsbuild commented Jun 1, 2016 •

edited

cmsbuild commented Jun 16, 2016 •

edited

mmusich commented Jun 17, 2016 •

edited