Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use unsigned in algebra #14699

Merged
merged 1 commit into from May 31, 2016

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented May 31, 2016

forward port of #14698

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_8_1_X.

It involves the following packages:

CalibCalorimetry/EcalLaserCorrection

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng, @argiro this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@VinInn
Copy link
Contributor Author

VinInn commented May 31, 2016

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 31, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13269/console

@VinInn
Copy link
Contributor Author

VinInn commented May 31, 2016

@emanueledimarco please ask to be informed when ECAL packages are modified

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented May 31, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit eb2f9f4 into cms-sw:CMSSW_8_1_X May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants