Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge request1231into root6branch #1470

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Nov 14, 2013

This is a snapshot of pull request 1231, but intended for the ROOT 6 branch instead of the main 7_0_X branch.
This will fix the compilation error in RecoVertex/BeamSpotProducer. It may be a long wait until pull request 1231 is pulled into a main release. I tried picking out just the minimal change for the compilation error, but that was not straightforward.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_0_ROOT6_X.

Merge request1231into root6branch

It involves the following packages:

Calibration/TkAlCaRecoProducers
DQM/BeamMonitor
RecoVertex/BeamSpotProducer
DQM/Physics
DQM/DTMonitorModule

@thspeer, @demattia, @danduggan, @rovere, @cmsbuild, @nclopezo, @rcastello, @deguio, @slava77, @eliasron can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@wmtan
Copy link
Contributor Author

wmtan commented Nov 14, 2013

David,
Please merge this unless it causes unforeseen problems. This allows RevoVertex/BeamSpotProducer to compile.

@davidlt
Copy link
Contributor

davidlt commented Nov 14, 2013

Trusting that you have tested it locally :) Merging.

davidlt added a commit that referenced this pull request Nov 14, 2013
@davidlt davidlt merged commit 7998a21 into cms-sw:CMSSW_7_0_ROOT6_X Nov 14, 2013
@wmtan
Copy link
Contributor Author

wmtan commented Nov 14, 2013

Yes, this pull request, plus checkdeps -a, all compiles against the latest ROOT6 IB.

@wmtan wmtan deleted the MergeRequest1231intoROOT6branch branch November 21, 2013 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants