Add more setters in CSCCorrelatedLCTDigi #14740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_8_1_X. It involves the following packages: DataFormats/CSCDigi @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
+1 |
cmsbuild
added
simulation-approved
fully-signed
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
dildick
deleted the
from-CMSSW_8_1_0_pre6-more-setters-for-CSC-LCT-dataformat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra setters will allow us to insert GEM-CSC bending angle information in the CSCCorrelatedLCTDigi dataformat, without actually changing the dataformat itself. Instead we will reinterpret 4 fields of the dataformat in the EMTF. These fields are pattern, quality, bending and valid.
There should be no change in the workflows for any era.