Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary cloning of particleFlowDisplacedVertex and pfCandidateToVertexAssociation in met corrections (backport of #14744) #14745

Merged

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Jun 2, 2016

(copied from 81X description)
modules with (currently) identical PSets independent of MET correction settings were cloned unnecessarily: particleFlowDisplacedVertex and pfCandidateToVertexAssociation were cloned to
*Puppi and *NoHF instances.
The extra CPU consumed by these in PU35 ttbar MC is about 3% of total event processing time.

If future implementations need these to be different, cloning of these modules can be re-enabled.
If there was no lingering need to support scheduled execution and if these modules were not in endpaths,
a solution could have been easier (just drop from the original sequence definition).

No changes in final results are expected (none were observed in local tests)

…ation in producePatPFMETCorrections and patPFMetT0CorrSequence postfix

Conflicts:
	PhysicsTools/PatUtils/python/tools/runMETCorrectionsAndUncertainties.py
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2016

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_0_X.

It involves the following packages:

PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor Author

slava77 commented Jun 2, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13326/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2016

@slava77
Copy link
Contributor Author

slava77 commented Jun 3, 2016

+1

for #14745 30298b0

  • jenkins test confirm no changes in monitored quantities, no issues

@slava77
Copy link
Contributor Author

slava77 commented Jun 20, 2016

@davidlange6
if there are no issues with this PR, it would help to merge in 80X to speedup promptreco by a few %

@davidlange6 davidlange6 merged commit 90838dd into cms-sw:CMSSW_8_0_X Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants