initialize apparently useless variables in GenMET

[slava77]

the goal is to avoid random numbers saved on disk to save space in compression and to minimize spurious differences in product size comparisons

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/METReco

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

Looking at wf 1330.0 (ZMM) with this PR vs baseline (CMSSW_8_1_X_2016-05-31-1100):

en->Scan("patMETs_slimmedMETs__RECO.obj.genMET_.gen_data.m_EmEnergy:\
eo.patMETs_slimmedMETs__RECO.obj.genMET_.gen_data.m_EmEnergy")
***********************************************
*    Row   * Instance * patMETs_s * eo.patMET *
***********************************************
*        0 *        0 *         0 * 9.279e+22 *
*        1 *        0 *         0 * 9.279e+22 *
*        2 *        0 *         0 * 9.279e+22 *
*        3 *        0 *         0 * 9.279e+22 *
*        4 *        0 *         0 * 9.279e+22 *

the desired result is achieved: we get 0 instead of some random large number.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13365/console

[cmsbuild]

+1
Tested at: 4019740
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14767/13365/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14767/13365/summary.html

[VinInn]

what about removing them for good?

[slava77]

On 6/4/16 9:10 AM, Vincenzo Innocente wrote:

what about removing them for good?

I'm leaving this to MET POG.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14767 (comment), or
mute the thread
https://github.com/notifications/unsubscribe/AEdcbgfMMO-D487ar0M_IRdRUef0WzvZks5qIaNtgaJpZM4It4Ty.

[slava77]

+1

for #14767 4019740

• jenkins tests pass and comparisons show no differences
• pre-submission tests showed the variables are initialized

@mmarionncern please check and remove the variables for good if they are not really needed or expected to be needed.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1