Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fasten pix hit matcher 80 x #14779

Merged
merged 2 commits into from Jun 7, 2016

Conversation

fcouderc
Copy link
Contributor

@fcouderc fcouderc commented Jun 6, 2016

Backport 81X code to make pixel seeding much faster...
remove Cxx flag compare last 80X PR
Needed for HLT urgently

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2016

A new Pull Request was created by @fcouderc for CMSSW_8_0_X.

It involves the following packages:

RecoEgamma/EgammaElectronAlgos

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Sam-Harper, @rafaellopesdesa, @lgray this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Jun 6, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13376/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2016

@fwyzard
Copy link
Contributor

fwyzard commented Jun 6, 2016

@slava77 , @cvuosalo , @davidlange6 , could you approve this for 8.0.x as well ?
We will need an 8.0.10-patch2 with it for online deployment.

@slava77
Copy link
Contributor

slava77 commented Jun 7, 2016

+1

for #14779 c6d0a00

  • changes in RecoEgamma/EgammaElectronAlgos/interface/PixelHitMatcher.h from 81X Speed seeding for HLT #13819 backported to 80X. THe goal is to reduce CPU use; no changes are expected in the outputs.
  • jenkins tests pass and comparisons with baseline show no differences
  • comparison in 134.902 (doubleEG from 2015D) shows that most of the speedup visible in Speed seeding for HLT #13819 in hltEgammaElectronPixelSeeds, hltEgammaElectronPixelSeedsUnseeded is present in this PR as well.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9935e22 into cms-sw:CMSSW_8_0_X Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants