Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to tau decay mode reconstruction #14795

Merged

Conversation

roger-wolf
Copy link
Contributor

Hi Slava, Carl,

We have made some changes to the tau decay mode reconstruction. This was in reaction to a significant unexpected efficiency loss in the 1prongNpi0 decay modes after the introduction of the 2prong reconstruction modes. Studies have been presented already quite some time ago (*). The main reason that has been identified is that a significant number of 1prongNpi0 taus were reconstructed in the 2prong reconstruction modes. Due to the reconstruction ordering of the algorithm, which prioritizes Nprong over Mprong for N>M these taus were lost in the 1prong decay modes. This has been counter measured by introducing a pT cut on the prongs for the reconstruction of the 2prong modes.

This pull request contains the following changes to tau decay mode reconstruction:

(1) an upper cut has been introduced on the prongs for all decay modes irrespective of the correction of the reconstructed tau direction (due to a better determination of ECAL clusters during reconstruction -- called bend corrections in the code; these corrections are additive);
(2) making bend corrections configurable (but switched on per default for all decay modes -- this is the same behaviour as currently in 81X, but there it is hard coded);
(3) adding a pT selection of pT>5GeV on the prongs for the reconstruction of the 2prong modes; this reduces unwanted migration effects and brings the efficiency of the 1prongNpi0 decay modes roughly back to the old level;
(4) the 3prong1pi0 decay mode has been added to the decay mode reconstruction by default; this gives an increase of the efficiency of up to +5%, though at the cost of a higher fakerate. It will still be used for dedicated analyses.

We have checked that (1) and (2) have minimal to no influence at all on the outcome of the tau Id sequences. (3) has a significant influence on the decay mode reconstruction, which has been checked to be in the right direction. The same is true for (4) but less significant. Validation sequences did not reveal any unexpected behaviour. Matrix tests were inconspicuous.

Cheers,
Roger

(*)
https://indico.cern.ch/event/477580/contributions/1998190/attachments/1209639/1763951/nehrkorn_2016_01_11.pdf

veelken and others added 8 commits January 21, 2016 10:57
…y apply bending corrections as done before (from 81X on but hard coded); Note that for XProng0Pi0 decay modes bending corrections are transparent; a hard coded cut on the upper boundary of the mass window per decay mode w/o bending corrections for all charged prongs has been added to PFRecoTauDiscriminationByHPSSelection.cc
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

A new Pull Request was created by @roger-wolf (Roger Wolf) for CMSSW_8_1_X.

It involves the following packages:

RecoTauTag/Configuration
RecoTauTag/RecoTau

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Jun 7, 2016

@cmsbuild please test

Roger, please clarify if the slides match the code introduced here.
Thanks.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13407/console

@roger-wolf
Copy link
Contributor Author

@slava77 as you see the slides are quite old. Therefore the match might not be 100%. But to >98% it should resemble the expectations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2016

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 9, 2016

+1

For #14795 0c91fc0

Making adjustments to tau decay mode reconstruction.

The code changes are satisfactory. Jenkins tests against baseline CMSSW_8_1_X_2016-06-06-2300 show no significant differences, except for numerous small differences in tau-related quantities, but these differences only amount to minor fluctuations and jitter. An example from workflow 1000.0 shows some slight improvement in decay mode finding efficiency:

eff

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cad0cb9 into cms-sw:CMSSW_8_1_X Jun 10, 2016
@roger-wolf roger-wolf deleted the CMSSW_8_1_X_tau-pog_decay-mode-changes branch August 8, 2016 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants