Updates in HGCAL L1 trigger #14831
Updates in HGCAL L1 trigger #14831
Conversation
Removing remaining tabs
…affioni/cmssw into baffioni-linearisation-810pre3
Baffioni linearisation 810pre3
TPG hexagonal geometry
cmsbuild
added
l1-pending
pending-signatures
tests-pending
comparison-pending
and removed
tests-started
labels
|
Pull request #14831 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again. |
|
Many thanks @davidlange6 for the comments. I have implemented the first two comments and commented on the last one. |
|
@cmsbuild please test |
|
@rekovic , @mulhearn, @davidlange6 could you please check again, eventually add more comments and eventually sign again? |
|
Hello, any news on this PR? |
|
@rekovic, @mulhearn, @davidlange6, this PR has been made 1 month ago and it has been 2 weeks since the comments have been answered. I know that phase-2 upgrades are not a priority, but could this be merged as soon as possible, or tell me what the showstopper is? |
|
@rekovic, @mulhearn Can you please pay attention to this PR. It has been reviewed by ORP and requires the sign off of L1. It has been 7 weeks since this PR was submitted and is necessary for moving forward with HGCal studies. If you require a presentation in a meeting, please let us know when and where! |
|
@rekovic, @mulhearn, since you already signed this PR before could you please just check the very small updates here 9506526 and sign again if it is ok. Any response would be highly appreciated. |
|
Dear @davidlange6, @mulhearn, @rekovic, |
|
please test |
|
The tests are being triggered in jenkins. |
|
@davidlange6, @mulhearn, @rekovic, now that there is a +1 from the tests, can we continue moving forward? |
|
@davidlange6 , @mulhearn , @rekovic , this PR needs to move forward urgently. |
|
lacking L1 feedback, I'll just merge it - I reviewed it a while ago. thanks for the ping |
This updates the HGCAL L1 trigger:
It depends on external cms-data/L1Trigger-L1THGCal#2
but tests can be run without these data.