Phase2 it pixel cluster cmssw 81 x #14854

emiglior · 2016-06-13T07:35:18Z

@boudoul @ebrondol @atricomi
DataFormats + producer for the Inner Tracker pixel clusters for phase2.
The new data format is essentially a clone of the present DataFormats/SiPixelCluster with modifications to the type of some data members to span the full module in case of small pitch pixels (e.g. pixel with column or row index larger than 2**8-1=255)
For the moment the new collection is not included in the phase2 workflows.

cmsbuild · 2016-06-13T07:35:42Z

A new Pull Request was created by @emiglior (Ernesto Migliore) for CMSSW_8_1_X.

It involves the following packages:

DataFormats/Phase2ITPixelCluster
Geometry/CaloEventSetup
Geometry/CaloTopology
Geometry/HcalTowerAlgo
RecoJets/Configuration
RecoLocalTracker/Phase2ITPixelClusterizer

The following packages do not have a category, yet:

DataFormats/Phase2ITPixelCluster
RecoLocalTracker/Phase2ITPixelClusterizer

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @jdolen, @makortel, @GiacomoSguazzoni, @rappoccio, @rovere, @VinInn, @ahinzmann, @nhanvtran, @schoef, @gpetruc, @mariadalfonso, @threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

ebrondol · 2016-06-13T08:23:55Z

@boudoul @kpedro88
Don't we want to put this in the 2023LReco WF?

kpedro88 · 2016-06-13T12:05:35Z

@ebrondol - assuming it's tested and works...

ebrondol · 2016-06-13T12:15:35Z

Yes, I think that @emiglior can provide a recipe to try that.

emiglior · 2016-06-13T15:22:27Z

@kpedro @ebrondol: what do you need exactly? I have my own version of the customize to produce these collections in the phase2 workflows.
Should I commit them too or just put them on some public repo?
Would it be possible to add them to this PR (#14854) without creating a new one?

kpedro88 · 2016-06-13T15:28:34Z

@emiglior if you have modified versions of the phase2TkFlat and phase2TkTilted customizations, I would commit them now. If you push the commit to this branch, it will update the PR automatically.

…flows

cmsbuild · 2016-06-13T15:50:28Z

Pull request #14854 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

kpedro88 · 2016-06-13T15:51:50Z

SLHCUpgradeSimulations/Configuration/python/phase2TkFlat.py

@@ -329,6 +336,6 @@ def customise_Reco(process,pileup):
    return process

 def customise_condOverRides(process):
-    process.load('SLHCUpgradeSimulations.Geometry.fakeConditions_phase2TkFlat_cff')
+    process.load('SLHCUpgradeSimulations.Geometry.fakeConditions_phase2TkTilted_cff')


Please fix this to be correct for the flat tracker case

…flows (small fix for flat scenario)

cmsbuild · 2016-06-13T15:58:09Z

Pull request #14854 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

atricomi · 2016-06-13T16:00:53Z

We should not modify the wf for the Flat geometry and we need to wait for the tilted one. The two new customizers are intended for test at the moment but not for the official wf. Please take care since I am scared we could break the official wf which currently does not include the new pixel geometry

Inviato da iPhone

Il giorno 13/giu/2016, alle ore 17:28, Kevin Pedro notifications@github.com ha scritto:

@emiglior if you have modified versions of the phase2TkFlat and phase2TkTilted customizations, I would commit them now. If you push the commit to this branch, it will update the PR automatically.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

atricomi · 2016-06-13T16:02:25Z

Ernesto io sono preoccupata che Kevin non abbia chiaro lo scenario noi non dobbiamo modificare i customizers in questo momento altrimenti rompiamo il wf. Io avrei preferito non venissero inseriti...

Inviato da iPhone

Il giorno 13/giu/2016, alle ore 17:22, Ernesto Migliore notifications@github.com ha scritto:

@kpedro @ebrondol: what do you need exactly? I have my own version of the customize to produce these collections in the phase2 workflows Should I commit them too or just put them on some public repo?
Would it be possible to add them to this PR (#14854) without creating a new one?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

emiglior · 2016-06-13T16:15:00Z

@atricomi I used the customizers on a "virgin" 81X (e.g. without the "dynamic v111" version of the Inner Pixel geometry) so they should not break the phase2 workflows...

slava77 · 2016-06-13T17:38:40Z

What's the value in
RecoLocalTracker/Phase2ITPixelClusterizer/test/testClusters.py
?
... or in
RecoLocalTracker/Phase2ITPixelClusterizer/test/ReadPixClusters.cc
?
Please cleanup.

cmsbuild · 2016-06-14T13:41:47Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2016-06-14T13:42:13Z

-1

Tested at: 78015e0

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14854/13495/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

 ^
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-14-1100/src/Geometry/CaloTopology/src/EcalTrigTowerConstituentsMap.cc:1:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-14-1100/src/Geometry/CaloTopology/interface/EcalTrigTowerConstituentsMap.h:10:33: warning: /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/boost/1.57.0-giojec/include/boost/tuple/tuple.hpp is shorter than expected
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-14-1100/src/Geometry/CaloTopology/test/HcalTopologyTester.cc 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-14-1100/src/Geometry/CaloTopology/src/EcalTrigTowerConstituentsMap.cc:1:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-14-1100/src/Geometry/CaloTopology/interface/EcalTrigTowerConstituentsMap.h:51:11: error: 'boost' does not name a type
   typedef boost::multi_index_container<
           ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-14-1100/src/Geometry/CaloTopology/interface/EcalTrigTowerConstituentsMap.h:59:11: error: 'EcalTowerMap' does not name a type
   typedef EcalTowerMap::nth_index<0>::type EcalTowerMap_by_DetId;
           ^

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 48 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

#19 0x0000003fcca1ed1d **libc_start_main (/lib64/libc.so.6+0x3fcca1ed1d)
#20 0x000000000040ca51 _start (/cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/llvm/3.8.0/bin/clang-3.8+0x40ca51)
Stack dump:
0. Program arguments: /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/llvm/3.8.0/bin/clang-3.8 -cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -disable-free -disable-llvm-verifier -main-file-name EcalTrigTowerConstituentsMapBuilder.cc -mrelocation-model pic -pic-level 2 -mthread-model posix -masm-verbose -mconstructor-aliases -munwind-tables -fuse-init-array -target-cpu x86-64 -target-feature +sse3 -momit-leaf-frame-pointer -dwarf-column-info -debugger-tuning=gdb -resource-dir /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/llvm/3.8.0/bin/../lib64/clang/3.8.0 -dependency-file tmp/slc6_amd64_gcc530/src/Geometry/CaloEventSetup/plugins/GeometryCaloEventSetupPlugins/EcalTrigTowerConstituentsMapBuilder.d -MT tmp/slc6_amd64_gcc530/src/Geometry/CaloEventSetup/plugins/GeometryCaloEventSetupPlugins/EcalTrigTowerConstituentsMapBuilder.o -D GNU_GCC -D _GNU_SOURCE -D CMSSW_GIT_HASH="CMSSW_8_1_X_2016-06-14-1100" -D PROJECT_NAME="CMSSW" -D PROJECT_VERSION="CMSSW_8_1_X_2016-06-14-1100" -D BOOST_SPIRIT_THREADSAFE -D PHOENIX_THREADSAFE -I /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-14-1100/src -I /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-06-14-1100/src -I /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/cms/coral/CORAL_2_3_21-giojec4/include/LCG -I /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/lcg/root/6.06.04-ocfgfb/include -I /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/boost/1.57.0-giojec/include -I /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/pcre/8.37/include -I /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/bz2lib/1.0.6/include -I /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/clhep/2.2.0.4-giojec2/include -I /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/gsl/1.16/include -I /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/libuuid/2.22.2/include -I /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/openssl/1.0.2d/include -I /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/python/2.7.11-giojec/include/python2.7 -I /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/tbb/44_20151115oss/include -I /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/xerces-c/2.8.0/include -I /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/zlib/1.2.8/include -D __STRICT_ANSI** -D BOOST_DISABLE_ASSERTS -internal-isystem /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/gcc/5.3.0/lib/gcc/x86_64-pc-linux-gnu/5.3.0/../../../../include/c++/5.3.0 -internal-isystem /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/gcc/5.3.0/lib/gcc/x86_64-pc-linux-gnu/5.3.0/../../../../include/c++/5.3.0/x86_64-pc-linux-gnu -internal-isystem /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/gcc/5.3.0/lib/gcc/x86_64-pc-linux-gnu/5.3.0/../../../../include/c++/5.3.0/backward -internal-isystem /usr/local/include -internal-isystem /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/llvm/3.8.0/bin/../lib64/clang/3.8.0/include -internal-externc-isystem /include -internal-externc-isystem /usr/include -O2 -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -Wstrict-overflow -Werror=array-bounds -Werror=type-limits -Wall -Wno-long-long -Wreturn-type -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=uninitialized -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=switch -Wno-unused-local-typedefs -Wno-attributes -Wno-c99-extensions -Wno-c++11-narrowing -Wno-unused-private-field -Wno-unknown-pragmas -Wno-unused-command-line-argument -Wno-error=potentially-evaluated-expression -Wno-error=unused-variable -Wno-error=unused-variable -std=c++14 -fdebug-compilation-dir /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-14-1100 -ftemplate-depth 512 -ferror-limit 19 -fmessage-length 0 -fvisibility-inlines-hidden -pthread -fobjc-runtime=gcc -fcxx-exceptions -fexceptions -fdiagnostics-show-option -vectorize-loops -vectorize-slp -x c++ /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-06-14-1100/src/Geometry/CaloEventSetup/plugins/EcalTrigTowerConstituentsMapBuilder.cc 
1.  parser at unknown location
clang-3.8: error: unable to execute command: Bus error
clang-3.8: error: clang frontend command failed due to signal (use -v to see invocation)
clang version 3.8.0 
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /cvmfs/cms-ib.cern.ch/2016-25/slc6_amd64_gcc530/external/llvm/3.8.0/bin

slava77 · 2016-06-14T14:00:38Z

@cmsbuild please test
@smuzaffar @iahmad-khan @Degano please check what's happening with the compilation. It's not the first time in the last couple of days.
It all typically starts with a lot of warning: null character(s) ignored

cmsbuild · 2016-06-14T14:00:55Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13500/console

emiglior · 2016-06-14T14:01:45Z

errors on ECAL and HCAL stuff are unexpected...
I was starting from the IB CMSSW_8_1_X_2016-06-08-1100 then merging in my installation the PR 14756. Something went probably wrong in this procedure.
I will start from the last IB and create a new PR

makortel · 2016-06-14T14:03:38Z

I've seen similar compilation problems on one (non-lxplus) machines at CERN. Upon inspection I've noticed some headers being empty in CVMFS leading to compilation errors (and I went to finish the compilation on some lxplus node).

kpedro88 · 2016-06-14T15:02:03Z

@emiglior - it looks like you might have included an old version of #14756. Try rebasing it out, since it's merged now.

cmsbuild · 2016-06-14T15:50:48Z

-1

Tested at: 78015e0

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14854/13500/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test Phase2PixelCluster_t had ERRORS

slava77 · 2016-06-14T16:29:04Z

DataFormats/Phase2ITPixelCluster/src/classes_def.xml

+   <![CDATA[thePixelCol = onfile.theMinPixelCol;]]>
+   </ioread>  
+   <ioread sourceClass="Phase2ITPixelCluster" version="[1-10]" targetClass="Phase2ITPixelCluster" source="uint32_t theMinPixelRow" target="thePixelRow">
+   <![CDATA[thePixelRow = onfile.theMinPixelRow;]]>


this file should be cleaned up from the nonexistent old versions

cmsbuild · 2016-06-14T20:05:31Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14854/13500/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2

emiglior · 2016-06-14T22:25:24Z

This PR is superseeded by PR #14885

emiglior added 6 commits June 9, 2016 14:11

add clusterizer for phase2 Inner Tracker Pixel

36f03e9

Merged phase2ITPixelCluster_cmssw_81X from repository emiglior

450aaa8

add phase2 Inner Tracker pixel clusterizer/ v2

4aa9671

add phase2 Inner Tracker pixel clusterizer/ v3

a2f6d21

Merged Phase2-WF7 from repository kpedro88

569a0da

phase2ITPixelCluster: add validation code

8858710

cmsbuild added this to the Next CMSSW_8_1_X milestone Jun 13, 2016

cmsbuild added reconstruction-pending geometry-pending pending-signatures tests-pending orp-pending new-package-pending comparison-pending labels Jun 13, 2016

customize's to add new phase2 Inner Pixel clusters to the phase2 work…

df522fe

…flows

cmsbuild added the simulation-pending label Jun 13, 2016

kpedro88 reviewed Jun 13, 2016
View reviewed changes

customize's to add new phase2 Inner Pixel clusters to the phase2 work…

23d8ca3

…flows (small fix for flat scenario)

cmsbuild added tests-started and removed tests-pending labels Jun 14, 2016

cmsbuild added comparison-notrun tests-rejected comparison-pending and removed comparison-pending comparison-notrun tests-started labels Jun 14, 2016

cmsbuild added tests-pending tests-started and removed tests-rejected tests-pending labels Jun 14, 2016

cmsbuild added tests-rejected and removed tests-started labels Jun 14, 2016

slava77 reviewed Jun 14, 2016
View reviewed changes

cmsbuild added comparison-available and removed comparison-pending labels Jun 14, 2016

emiglior mentioned this pull request Jun 14, 2016

Add phase2 Inner Tracker (IT) pixel cluster to cmssw 81X from new IB #14885

Merged

emiglior closed this Jun 14, 2016

emiglior deleted the phase2ITPixelCluster_cmssw_81X branch June 20, 2016 17:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2 it pixel cluster cmssw 81 x #14854

Phase2 it pixel cluster cmssw 81 x #14854

emiglior commented Jun 13, 2016

cmsbuild commented Jun 13, 2016

ebrondol commented Jun 13, 2016

kpedro88 commented Jun 13, 2016

ebrondol commented Jun 13, 2016

emiglior commented Jun 13, 2016 •

edited

kpedro88 commented Jun 13, 2016

cmsbuild commented Jun 13, 2016

kpedro88 Jun 13, 2016

cmsbuild commented Jun 13, 2016

atricomi commented Jun 13, 2016

atricomi commented Jun 13, 2016

emiglior commented Jun 13, 2016

slava77 commented Jun 13, 2016

cmsbuild commented Jun 14, 2016

cmsbuild commented Jun 14, 2016

slava77 commented Jun 14, 2016

cmsbuild commented Jun 14, 2016 •

edited

emiglior commented Jun 14, 2016

makortel commented Jun 14, 2016

kpedro88 commented Jun 14, 2016

cmsbuild commented Jun 14, 2016

slava77 Jun 14, 2016

cmsbuild commented Jun 14, 2016

emiglior commented Jun 14, 2016

Phase2 it pixel cluster cmssw 81 x #14854

Phase2 it pixel cluster cmssw 81 x #14854

Conversation

emiglior commented Jun 13, 2016

cmsbuild commented Jun 13, 2016

ebrondol commented Jun 13, 2016

kpedro88 commented Jun 13, 2016

ebrondol commented Jun 13, 2016

emiglior commented Jun 13, 2016 • edited

kpedro88 commented Jun 13, 2016

cmsbuild commented Jun 13, 2016

kpedro88 Jun 13, 2016

Choose a reason for hiding this comment

cmsbuild commented Jun 13, 2016

atricomi commented Jun 13, 2016

atricomi commented Jun 13, 2016

emiglior commented Jun 13, 2016

slava77 commented Jun 13, 2016

cmsbuild commented Jun 14, 2016

cmsbuild commented Jun 14, 2016

slava77 commented Jun 14, 2016

cmsbuild commented Jun 14, 2016 • edited

emiglior commented Jun 14, 2016

makortel commented Jun 14, 2016

kpedro88 commented Jun 14, 2016

cmsbuild commented Jun 14, 2016

slava77 Jun 14, 2016

Choose a reason for hiding this comment

cmsbuild commented Jun 14, 2016

emiglior commented Jun 14, 2016

emiglior commented Jun 13, 2016 •

edited

cmsbuild commented Jun 14, 2016 •

edited