New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing HLT to be seeded by Taus #14903
Conversation
A new Pull Request was created by @Sam-Harper for CMSSW_8_0_X. It involves the following packages: HLTrigger/Egamma @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
@Sam-Harper, all, I think I have some general comments about this module - irrespective of the urgent addition of tau candidates to the seeds. Who do you think I should bother with them ? |
Yes I agree its a bit nasty. I would talk to Afiq about them. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
@Sam-Harper , do you also need a similar change in |
Hi Andrea, I'm happy enough. I get tau matches with this filter. No HLTEcalRecHitInAllL1RegionsProducer is all setup, either Gabi or Afiq had the forsight to do that. I've just proved in fact that module does accept taus . Cheers, |
Hi David,
could you build an 8.0.x patch release with this PR ?
If it's the same for you, I would prefer an 8.0.10-patch3 , as it would be
easier and faster to switch online.
If that is problematic, for any reasons, then 8.0.11-patch1 will be fine.
Thank you,
.Andrea
|
Should be ok with 8_0_10 patch. I'll have a look Sent from my iPad On Jun 16, 2016, at 6:02 PM, Andrea Bocci <notifications@github.commailto:notifications@github.com> wrote: Hi David, If it's the same for you, I would prefer an 8.0.10-patch3 , as it would be Thank you, — |
@Sam-Harper |
+1 |
Dear All,
The L1EG efficiency is poor at high pt and we need to OR with Tau seeds to recover this. This requires the following change to the seeding module.
My small scale test showed that it was correctly matching with taus, now going for a larger scale test
Cheers,
Sam