protect tsos

[VinInn]

following report of segfault

[VinInn]

@cmsbuild , please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13611/console

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_8_0_X.

It involves the following packages:

TrackingTools/TrajectoryFiltering

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @gpetruc, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[cmsbuild]

+1
Tested at: d791f17
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14943/13611/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14943/13611/summary.html

[slava77]

I tested with Giovanni's config from
https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1455.html
this is reproducible faster with

process.source.skipEvents = cms.untracked.uint32(5400+24)
process.maxEvents.input = 1
process.options.numberOfThreads = 1
process.source.fileNames = [ "root://eoscms.cern.ch//eos/cms/tier0/store/data/Run2016B/HTMHT/RAW/v2/000/274/968/00000/24E63E72-7730-E611-8F78-02163E01449D.root" ]

without this PR the event processing terminates after spewing errors in the following

count type category module
      1 %MSG-e KFUpdator: ConversionTrackCandidateProducer:conversionTrackCandidates
    230 %MSG-w BasicTrajectoryState: ConversionTrackCandidateProducer:conversionTrackCandidates
      6 %MSG-w FreeTrajectoryState: ConversionTrackCandidateProducer:conversionTrackCandidates

with this PR , the event processing completes with more noise still

     21 %MSG-e KFUpdator: ConversionTrackCandidateProducer:conversionTrackCandidates
      1 %MSG-e MatrixInversionFailure: TrackProducerWithSCAssociation:ckfInOutTracksFromConversions
    446 %MSG-w BasicTrajectoryState: ConversionTrackCandidateProducer:conversionTrackCandidates
     17 %MSG-w BasicTrajectoryState: TrackProducerWithSCAssociation:ckfInOutTracksFromConversions
     23 %MSG-w FreeTrajectoryState: ConversionTrackCandidateProducer:conversionTrackCandidates

Most warnings are BasicTrajectoryState: attempt to access errors when none available
Among the first warnings/errors are for FTS with (in order of appearance; count is prepended for sequentially repeated) all with LocalError with either large value or inf.

      3 p =  -3.28379e-07 -1.06546e-07 -8.88994e-07
      2 p =   -3.4433e+08 -1.11722e+08 -9.32178e+08
      1 p =   -3.4433e+08 -1.11722e+08 -9.32177e+08
     16 p =  -2.36585e+08 -7.67626e+07 -6.40487e+08

the first set has x = 23.7156 -58.5148 -63.8482 and LocalError 0,0 of -inf.

The fix in this PR looks safe and appropriate.
It would be nice to track down the issue upstream.

[slava77]

+1

for #14943 d791f17

• code change is as described, to address a crash reported in https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1455/1/1.html
  • only events that would otherwise crash the processing are affected
• jenkins tests pass
• the crash was reproduced locally and is confirmed to be gone with this update

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1