Fix array bounds overrun in DetectPatterns(), 80x version #14955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @dan131riley (Dan Riley) for CMSSW_8_0_X. It involves the following packages: L1Trigger/L1TMuonEndCap @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
Thanks! |
|
please test |
|
The tests are being triggered in jenkins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
80x backport of the fix in #14941 as requested by @Martin-Grunewald in comments to that PR.
The DetectPatterns() routine was running off both ends of the ranka_t vector due to a misplaced bounds check. This was causing occasional crashes, particularly in the multi-threaded integration builds where the memory layout is more scattered.
I also added "const" to some file-level statics that our static code analyzer complains about.