Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation/RecoParticleFlow : gcc 6.0 misleading-indentation warning flags potential bug; with bug fix #14999

Merged
merged 3 commits into from
Jun 29, 2016
Merged

Validation/RecoParticleFlow : gcc 6.0 misleading-indentation warning flags potential bug; with bug fix #14999

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b17f72c
Fix this 'if' clause does not guard... [-Wmisleading-indentation]
gartung Jun 27, 2016
439b47f
how the compiler sees it
gartung Jun 27, 2016
8c2c839
probably what author intended
gartung Jun 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Validation/RecoParticleFlow/bin/include/Plot1D.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ void PlotCompareUtility::makePlots<Plot1D>(HistoData *HD) {

// place the test results as the title
TString title = HD->getName();
if (ksThreshold > 0) title += " KS Score = "; title += HD->getKSScore();
if (chi2Threshold > 0) title += " Chi^2 Score = "; title += HD->getChi2Score();
if (ksThreshold > 0) {title += " KS Score = "; title += HD->getKSScore();}
Copy link
Member Author

@gartung gartung Jun 28, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the author intend for these two statements to be enclosed in curly braces?

if (chi2Threshold > 0) { title += " Chi^2 Score = "; title += HD->getChi2Score();}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question.


// the canvas is rescaled during gif conversion, so add padding to Canvas dimensions
int plotsCanvasWidth = plotsWidth + 4;
Expand Down