Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hltDiff: fix comparison of trigger candidates with different process name #15012

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jun 28, 2016

fix the comparison of the trigger candidates when the old and new collections have a different process name

…d and new collections have a different process name
@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 28, 2016

+1

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 28, 2016

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Jun 28, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 28, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13718/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_8_0_X.

It involves the following packages:

HLTrigger/Tools

@cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 28, 2016

@davidlange6 , could you pick this up for the next 8.0.x release as well ?

@cmsbuild
Copy link
Contributor

-1

Tested at: b7dfc04

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15012/13718/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
50202.0 step3
runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
4.22 step1
DAS Error
140.53 step1
DAS Error

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 28, 2016 via email

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 28, 2016 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 28, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13725/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6c15fdc into cms-sw:CMSSW_8_0_X Jun 28, 2016
@fwyzard fwyzard deleted the hltDiff_fix_process_name_in_candidates branch June 28, 2016 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants