Get rid of standAloneSETMuons

[fcavallo]

No description provided.

[cmsbuild]

A new Pull Request was created by @fcavallo (Francesca Romana Cavallo) for CMSSW_8_0_X.

It involves the following packages:

DQM/DTMonitorModule

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[jhgoh]

@fcavallo , will it be OK if I merge this PR to the #14747 ?

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13888/console

[cmsbuild]

+1
Tested at: 823f265
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15015/13888/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15015/13888/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[cvuosalo]

hold

[cmsbuild]

Pull request has been put on hold by @cvuosalo
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cvuosalo]

@fcavallo: DT DQM plots in Jenkins DQM results are now empty. Why are they not getting filled by the standaloneMuons?

[fcavallo]

the reason is that for SET muons the associated hits were real hits while for standAlone they are segment (hence much less) I am just retuning the cut on the minimum number or hits

[cmsbuild]

Pull request #15015 was updated. @perrotta, @cmsbuild, @dmitrijus, @Martin-Grunewald, @fwyzard, @vanbesien, @davidlange6 can you please check and sign again.

[cvuosalo]

@fcavallo: There are now merge conflicts. I don't understand the trigger code you've merged in.

[slava77]

why is this in 80X?
The PR that initiated the issue was for 81X.
We should start with 81X and then backport, if necessary.

[fcavallo]

I have no idea what the HLTrigger folder has to do with me! In my local area I only have DQM/DTMonitorModule and I just changed a line and committed the following configuration file:
git commit -m "change default parameter for standAloneMuons" DQM/DTMonitorModule/python/dtChamberEfficiency_cfi.py Then:
git push my-cmssw noSETMuons
which was supposed to update my previous PR #15015
Does anybody know what happened and if I did anything wrong??

[jhgoh]

@fcavallo well, it happens when switching over different branches.
In any case, we need new PR to push into 81X and this should be closed.
Are you going to open new PR? Just in case you are busy, I can make new one to save your time. The change seem to be very simple by looking at your code changes here.

[fcavallo]

yes it IS so simple (even though I had to do some tests, before choosing a -hopefully- sensible value)
Now I've sent another PR in 81x. I hope it's fine this time (at least I don't seem to have dragged with me any unwanted extra-folder!!). If SET muons will be kept in 80x, I don't need 15015 any more. Thank you for your patience!

[Martin-Grunewald]

-1
does not merge - also remove the two HLT changed files.

[fcavallo]

Hi. In the end, if the actual SETMuons suppression is only scheduled for 81x (is this right??), we don't need this PR in 80x. I already sent another PR (#15144) for 81x and I think this one might be closed.
(btw the HLT files were just an unwanted result of merging branches and PR's. Apologies for that.)

[Martin-Grunewald]

Then I suggest you close this PR!