Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timing VS lumi (for HLT monitoring) #15169

Merged
merged 3 commits into from Jul 28, 2016

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Jul 12, 2016

it was #14938
but because of issues w/ the synch between 81x and 80x
I preferred to have a dedicated branch for 80x

hope everything is fine, now
sorry for the confusion !
@fwyzard @dmitrijus @vanbesien @Martin-Grunewald @perrotta

get 81x GetLumi.h
Conflicts:
	DQM/TrackingMonitor/interface/GetLumi.h
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_0_X.

It involves the following packages:

DQM/HLTEvF
DQM/Integration
DQM/TrackingMonitor
HLTrigger/Timer

@perrotta, @cmsbuild, @dmitrijus, @Martin-Grunewald, @fwyzard, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@batinkov, @hdelanno, @makortel, @Martin-Grunewald, @fioriNTU, @idebruyn, @threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 15, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14084/console

@perrotta
Copy link
Contributor

In DQM/TrackingMonitor/interface/GetLumi.h, with respect to the 81X version you miss the SQRT_S_13TeV in enum: I think you must fix it here.

@cmsbuild
Copy link
Contributor

-1

Tested at: 796ad52

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15169/14084/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
25202.0 step3
runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
136.731 step1
DAS Error
140.53 step1
DAS Error
1000.0 step1
DAS Error
1001.0 step1
DAS Error
1003.0 step1
DAS Error

@fwyzard
Copy link
Contributor

fwyzard commented Jul 18, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 18, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14137/console

@fwyzard
Copy link
Contributor

fwyzard commented Jul 18, 2016

backport of #14937

@fwyzard
Copy link
Contributor

fwyzard commented Jul 18, 2016

+1

@perrotta
Copy link
Contributor

@mtosi , @fwyzard : before testing further, I would like to see an answer to my comment above:
"In DQM/TrackingMonitor/interface/GetLumi.h, with respect to the 81X version you miss the SQRT_S_13TeV in enum: I think you must fix it here."

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 18, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14142/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants