New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add timing VS lumi (for HLT monitoring) #15169
Conversation
get 81x GetLumi.h
Conflicts: DQM/TrackingMonitor/interface/GetLumi.h
A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_0_X. It involves the following packages: DQM/HLTEvF @perrotta, @cmsbuild, @dmitrijus, @Martin-Grunewald, @fwyzard, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
In DQM/TrackingMonitor/interface/GetLumi.h, with respect to the 81X version you miss the SQRT_S_13TeV in enum: I think you must fix it here. |
-1 Tested at: 796ad52 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log25202.0 step3 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log136.731 step1 DAS Error140.53 step1 DAS Error1000.0 step1 DAS Error1001.0 step1 DAS Error1003.0 step1 DAS Error |
please test |
The tests are being triggered in jenkins. |
backport of #14937 |
+1 |
+1 |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
it was #14938
but because of issues w/ the synch between 81x and 80x
I preferred to have a dedicated branch for 80x
hope everything is fine, now
sorry for the confusion !
@fwyzard @dmitrijus @vanbesien @Martin-Grunewald @perrotta