New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: eval_auto_bounds returns good value for pt==pt_low #15283
fix: eval_auto_bounds returns good value for pt==pt_low #15283
Conversation
A new Pull Request was created by @HeinerTholen for CMSSW_8_1_X. It involves the following packages: CondTools/BTau @ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
Hi @HeinerTholen @ggovi - this change is naively unusual - is there more of an explanation elsewhere? (or maybe its just the consumer code that I need to be pointed to) |
Hi @davidlange6 @ggovi, @imarches, @pvmulder The code is used by analysis users to retrieve btag scale factors. Only when a pt value exactly at the lower bound is given, a value of zero was returned. Since this is rarely the case, it's a minor bug, I would say. But it should be fixed. |
i misread the code before - looks good to me now (though perhaps its more usual to include the lower limit in the bin rather than the upper limit..) Thanks |
Same as #15282.
(This fixes an error where eval_auto_bounds would return zero if the pt value at lower bound is given.)