CTPPS: directory rename Totem -> CTPPS

[jan-kaspar]

Several "Totem" directories renamed to simplify code sharing with other CTPPS detectors.

Directories renamed:

• DataFormats/TotemRPDetId --> DataFormats/CTPPSDetId
• DataFormats/TotemDigi --> DataFormats/CTPPSDigi
• CondFormats/TotemReadoutObjects --> CondFormats/CTPPSReadoutObjects
• EventFilter/TotemRawToDigi --> EventFilter/CTPPSRawToDigi

Directories not renamed:

• RecoCTPPS/TotemRPLocal: no code sharing expected, each detector expected to have its own subdirectory

Config files successfully tested:

• EventFilter/CTPPSRawToDigi/test/global_daq_test.py
• EventFilter/CTPPSRawToDigi/test/analyze_vfat_frames.py
• Geometry/VeryForwardGeometryBuilder/test/GeometryInfo_cfg.py
• RecoCTPPS/Configuration/test/raw_data_test.py
• DQM/CTPPS/test/dqm_test_cfg.py
• DQM/Integration/python/clients/ctpps_dqm_sourceclient-live_cfg.py

[cmsbuild]

A new Pull Request was created by @jan-kaspar for CMSSW_8_1_X.

It involves the following packages:

CondFormats/CTPPSReadoutObjects
Configuration/StandardSequences
DQM/CTPPS
DQM/Integration
DataFormats/CTPPSDetId
DataFormats/CTPPSDigi
EventFilter/CTPPSRawToDigi
EventFilter/TotemRawToDigi
Geometry/VeryForwardGeometryBuilder
RecoCTPPS/Configuration
RecoCTPPS/TotemRPLocal

The following packages do not have a category, yet:

CondFormats/CTPPSReadoutObjects
DataFormats/CTPPSDetId
DataFormats/CTPPSDigi
EventFilter/CTPPSRawToDigi

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @franzoni, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @batinkov, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @threus, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14261/console

[cmsbuild]

+1
Tested at: 04f90bc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15311/14261/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a08ea99
0fc09d4
9559a55
713ac2f
130aca9
163c0ef
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15311/14261/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15311/14261/git-merge-result

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15311/14261/summary.html

[cvuosalo]

DataFormats/CTPPSDetId/src/classes_def.xml contains the obsolete name TotemRPDetId that needs to be changed.

[jan-kaspar]

@cvuosalo I actually believe this is correct: only directories were renamed, not files nor classes. Thus the class is still called TotemRPDetId:
https://github.com/CTPPS/cmssw/blob/04f90bc1161937102f32769faa22ba321c2a3392/DataFormats/CTPPSDetId/interface/TotemRPDetId.h#L51

[ianna]

+1

[cvuosalo]

@jan-kaspar: I think this TotemRPDetId error message for a lost def is just transitional due to the name changes:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15311/14261/dupDict/lostDefs.txt

After this PR is merged, please take a look at a subsequent IB and make sure that there are no lingering classes_def problems. Thanks.

[cvuosalo]

+1

For #15311 04f90bc

Renaming TOTEM directories for CT-PPS. There should be no change in monitored quantities.

#15317 is the 80X version of this PR.

The changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-07-27-1100 show no significant differences, as expected. Phase 1 workflows show unrelated differences caused by the additional PRs Jenkins included in the tests.

[dmitrijus]

+1