Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define condition objects for Ecal time bias corrections (reco). #1535

Merged
merged 1 commit into from Nov 22, 2013

Conversation

dmitrijus
Copy link
Contributor

Currently, RecoLocalCalo.EcalRecProducers.EcalUncalibRecHitWorkerGlobal
(ecal reconstruction)
uses a list of hardcoded parameters for time bias correction.
To increase the flexibily they will be moved into a database payload.

Currently, RecoLocalCalo.EcalRecProducers.EcalUncalibRecHitWorkerGlobal
(ecal reconstruction)
uses a list of hardcoded parameters for time bias correction.
To increase the flexibily they will be moved into a database payload.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_0_X.

Define condition objects for Ecal time bias corrections (reco).

It involves the following packages:

CondCore/EcalPlugins
CondFormats/DataRecord
CondFormats/EcalObjects

@apfeiffer1, @nclopezo, @demattia, @cmsbuild, @rcastello, @ggovi can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@apfeiffer1
Copy link
Contributor

+1

1 similar comment
@demattia
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Nov 22, 2013

Following today decision at the XC, 70X is back in business. Merging this.

ktf added a commit that referenced this pull request Nov 22, 2013
Alca updates -- Define condition objects for Ecal time bias corrections (reco).
@ktf ktf merged commit 4bff48d into cms-sw:CMSSW_7_0_X Nov 22, 2013
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants