Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CastorBaseMonitor module removed, cleaning the rest Castor DQM modules #15350

Merged
merged 9 commits into from Oct 18, 2016

Conversation

popovvp
Copy link
Contributor

@popovvp popovvp commented Aug 2, 2016

removed subFolder CastorEventProducts (Event Products plots moved to "Castor" subFolder
removed CastorBaseMonitor module
removed obsolete stuff from Castor modules
fixed bug in jet access

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2016

A new Pull Request was created by @popovvp for CMSSW_8_1_X.

It involves the following packages:

DQM/CastorMonitor

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@popovvp popovvp changed the title Dqm810p9 bug fixed and removing obsolete stuff Aug 2, 2016
@popovvp popovvp changed the title bug fixed and removing obsolete stuff bug fixed and obsolete stuff removed Aug 2, 2016
@@ -14,22 +14,24 @@
//======================= Constructor ==============================//
CastorRecHitMonitor::CastorRecHitMonitor(const edm::ParameterSet& ps)
{
std::cout<<"CastorRecHitMonitor Constructor: "<<this<<std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14438/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2016

@davidlange6
Copy link
Contributor

@popovvp - please update the title of this PR with a meaningful description for the release notes. Thanks. (eg, a bug fix in what part of cmssw?)

@popovvp popovvp changed the title bug fixed and obsolete stuff removed CastorBaseMonitor module removed, cleaning the rest modules Aug 11, 2016
@popovvp popovvp changed the title CastorBaseMonitor module removed, cleaning the rest modules CastorBaseMonitor module removed, cleaning the rest Castor DQM modules Aug 11, 2016
@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bb1721a into cms-sw:CMSSW_8_1_X Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants