Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-alca55 Correct G4 validation code using isolated particles #15352

Merged
merged 1 commit into from Aug 5, 2016

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Aug 2, 2016

This code is used to validate G4 physics with collision data

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2016

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

Calibration/IsolatedParticles

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 2, 2016

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14330/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2016

-1

Tested at: 1b255c6

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15352/14330/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 3, 2016

@smuzaffar @davidlange6 The tests are failing because of DAS error in one example. It is happening in all PR's. Can this be fixed?

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 4, 2016

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14351/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2016

-1

Tested at: 1b255c6

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15352/14351/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error
1001.0 step1
DAS Error
1003.0 step1
DAS Error

@bsunanda
Copy link
Contributor Author

bsunanda commented Aug 4, 2016

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14364/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2016

-1

Tested at: 1b255c6

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15352/14364/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error

@mmusich
Copy link
Contributor

mmusich commented Aug 5, 2016

+1
(will need to see the tests though)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants